-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Necessary update on the formal vocabulary? #322
Comments
add 5.
The paragraph language could be more straightforward, but it says that |
Thanks @filip26. But...
Well, that is not the way I read that sentence! The sentence says that the:
My reading of this is literal: there is, somewhere, a JSON-LD document, declared as a controller document, which contains a Yes, some clarification may indeed be needed. cc @dlongley @msporny (my apologies not to have cc-d you before). |
@iherman Thanks, I see your point. My interpretation is biased by how it works with DID URL when passed as a |
@iherman if this is an update to the security vocabulary, we'll need to transfer the issue to the vc-data-integrity repo and raise the PR there. I'm ambivalent wrt. the need to do this as it won't affect any of the current implementations, AFAICT. I'm fine to do it for reasons of completeness. Wondering what @dlongley feels about all of the above? In any case, I raised PR #320 to address this issue. This issue will be closed once PR #320 has been merged. |
@msporny I will take over the #320 (see #320 (comment)). I also made a comment originally
but that is probably the same discussion/issue as in w3c/cid#119 (comment). |
Maybe the class should really be called Does the "id" identify the controller, or the document which describes the controller? :) |
The |
PR #320 has been merged, closing. |
Reading through w3c/cid#116 it helped me to understand some things. My way of getting my thoughts in order was to try to map what I read to the security vocabulary (which is, after all, simple ontology).
To check my understanding, I believe the following statements are true (some are trivial, some less):
Looking at the vocabulary (see also its graphic representation) we are almost o.k. but not fully. The glaring (and significant) missing concept is the ControllerDocument. Per (1) above I believe it should be added as a separate class and, per (4) it should be an alternative domain for the controller property.
(Note that the alsoKnownAs and service properties, though listed in the specification as properties on controller document, do not appear in the vocabulary or in its diagram. That is because these two properties are "borrowed" from other vocabularies.)
Long story short, I believe the following changes should be done on the vocabulary:
I also believe that the statement (5) is not absolutely obvious from the current text, and it should be reinforced somehow...
The text was updated successfully, but these errors were encountered: