Skip to content

Commit f8b7e0d

Browse files
authored
Merge pull request #248 from youennf/do-not-resolve-in-parallel-steps
Queue a task before resolving/rejecting promises
2 parents dacdedb + ac2c456 commit f8b7e0d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

index.bs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,7 @@ The <dfn abstract-op>generate key frame algorithm</dfn>, given |promise|, |encod
10441044
1. Gather a list of video encoders, named |videoEncoders| from |encoder|, ordered according negotiated RIDs if any.
10451045
1. If |rid| is defined, remove from |videoEncoders| any video encoder that does not match |rid|.
10461046
1. If |rid| is undefined, remove from |videoEncoders| all video encoders except the first one.
1047-
1. If |videoEncoders| is empty, reject |promise| with {{NotFoundError}} and abort these steps.
1047+
1. If |videoEncoders| is empty, [=queue a task=] to reject |promise| with {{NotFoundError}} and abort these steps.
10481048
|videoEncoders| is expected to be empty if the corresponding {{RTCRtpSender}} is not active, or the corresponding {{RTCRtpSender}} track is ended.
10491049
1. Let |videoEncoder| be the first encoder in |videoEncoders|.
10501050
1. If |rid| is undefined, set |rid| to the RID value corresponding to |videoEncoder|.
@@ -1075,7 +1075,7 @@ The <dfn abstract-op>send request key frame algorithm</dfn>, given |promise| and
10751075
1. If sending a Full Intra Request (FIR) by |depacketizer|'s receiver is not deemed appropriate, [=resolve=] |promise| with undefined and abort these steps.
10761076
Section 4.3.1 of [[RFC5104]] provides guidelines of how and when it is appropriate to sending a Full Intra Request.
10771077
1. Generate a Full Intra Request (FIR) packet as defined in section 4.3.1 of [[RFC5104]] and send it through |depacketizer|'s receiver.
1078-
1. [=Resolve=] |promise| with undefined.
1078+
1. [=Queue a task=] to [=resolve=] |promise| with undefined.
10791079

10801080
# RTCRtpSender extension # {#rtcrtpsender-extension}
10811081

0 commit comments

Comments
 (0)