Skip to content

Add a clone operator to RTCEncodedVideoFrame #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alvestrand opened this issue Nov 27, 2022 · 1 comment
Closed

Add a clone operator to RTCEncodedVideoFrame #161

alvestrand opened this issue Nov 27, 2022 · 1 comment

Comments

@alvestrand
Copy link
Collaborator

alvestrand commented Nov 27, 2022 •
edited by aboba
Loading

in support of solving #160, the RTCEncodedVideoFrame should have a clone() method, mimicking the pattern used for tracks.

Use case: https://w3c.github.io/webrtc-nv-use-cases/#auction
alvestrand added a commit that referenced this issue Nov 28, 2022
@alvestrand
Add clone() method
f865b32 
Fixes #161
@alvestrand alvestrand mentioned this issue Nov 28, 2022
Closed
ibaoger pushed a commit to ibaoger/webrtc that referenced this issue Jan 13, 2023
@henbos
Add GetRTPVideoHeaderCodecSpecifics() to metadata.
dc39aeb 
This will allow exposing VP8, VP9 and H264-specific RTP header metadata
in JavaScript (behind a flag).

This information appears to be necessary for cloning
(w3c/webrtc-encoded-transform#161), and
cloning should be the same as "new frame + setMetadata + setBytes",
ergo this should be exposed.

Bug: webrtc:14709
Change-Id: Ie71c05f40689bbd529dc4674a07a87c7910b22d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290880
Reviewed-by: Harald Alvestrand <[email protected]>
Commit-Queue: Henrik Boström <[email protected]>
Cr-Commit-Position: refs/heads/main@{#39101}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue May 12, 2023
@mfromanmoz
Bug 1828517 - Vendor libwebrtc from dc39aebd08
ebff363 
Upstream commit: https://webrtc.googlesource.com/src/+/dc39aebd08a845849b255122fcd5167308e122d2
    Add GetRTPVideoHeaderCodecSpecifics() to metadata.

    This will allow exposing VP8, VP9 and H264-specific RTP header metadata
    in JavaScript (behind a flag).

    This information appears to be necessary for cloning
    (w3c/webrtc-encoded-transform#161), and
    cloning should be the same as "new frame + setMetadata + setBytes",
    ergo this should be exposed.

    Bug: webrtc:14709
    Change-Id: Ie71c05f40689bbd529dc4674a07a87c7910b22d5
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290880
    Reviewed-by: Harald Alvestrand <[email protected]>
    Commit-Queue: Henrik Boström <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#39101}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue May 16, 2023
@marco-c
Bug 1828517 - Vendor libwebrtc from dc39aebd08
6545eea 
Upstream commit: https://webrtc.googlesource.com/src/+/dc39aebd08a845849b255122fcd5167308e122d2
    Add GetRTPVideoHeaderCodecSpecifics() to metadata.

    This will allow exposing VP8, VP9 and H264-specific RTP header metadata
    in JavaScript (behind a flag).

    This information appears to be necessary for cloning
    (w3c/webrtc-encoded-transform#161), and
    cloning should be the same as "new frame + setMetadata + setBytes",
    ergo this should be exposed.

    Bug: webrtc:14709
    Change-Id: Ie71c05f40689bbd529dc4674a07a87c7910b22d5
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290880
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Commit-Queue: Henrik Boström <hboswebrtc.org>
    Cr-Commit-Position: refs/heads/main{#39101}

UltraBlame original commit: 24feef30dccd8376febdd220ce81ee8a5a99953c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue May 16, 2023
@marco-c
Bug 1828517 - Vendor libwebrtc from dc39aebd08
4c2082e 
Upstream commit: https://webrtc.googlesource.com/src/+/dc39aebd08a845849b255122fcd5167308e122d2
    Add GetRTPVideoHeaderCodecSpecifics() to metadata.

    This will allow exposing VP8, VP9 and H264-specific RTP header metadata
    in JavaScript (behind a flag).

    This information appears to be necessary for cloning
    (w3c/webrtc-encoded-transform#161), and
    cloning should be the same as "new frame + setMetadata + setBytes",
    ergo this should be exposed.

    Bug: webrtc:14709
    Change-Id: Ie71c05f40689bbd529dc4674a07a87c7910b22d5
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290880
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Commit-Queue: Henrik Boström <hboswebrtc.org>
    Cr-Commit-Position: refs/heads/main{#39101}

UltraBlame original commit: 24feef30dccd8376febdd220ce81ee8a5a99953c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue May 16, 2023
@marco-c
Bug 1828517 - Vendor libwebrtc from dc39aebd08
621ea9d 
Upstream commit: https://webrtc.googlesource.com/src/+/dc39aebd08a845849b255122fcd5167308e122d2
    Add GetRTPVideoHeaderCodecSpecifics() to metadata.

    This will allow exposing VP8, VP9 and H264-specific RTP header metadata
    in JavaScript (behind a flag).

    This information appears to be necessary for cloning
    (w3c/webrtc-encoded-transform#161), and
    cloning should be the same as "new frame + setMetadata + setBytes",
    ergo this should be exposed.

    Bug: webrtc:14709
    Change-Id: Ie71c05f40689bbd529dc4674a07a87c7910b22d5
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290880
    Reviewed-by: Harald Alvestrand <htawebrtc.org>
    Commit-Queue: Henrik Boström <hboswebrtc.org>
    Cr-Commit-Position: refs/heads/main{#39101}

UltraBlame original commit: 24feef30dccd8376febdd220ce81ee8a5a99953c
@alvestrand alvestrand mentioned this issue Jun 1, 2023
Closed
Closed
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 12, 2023
@palak8669 @chromium-wpt-export-bot
Allow RTCEncodedAudioFrame's timestamp to be modified
5bef30c 
This is in related to the use cases mentioned in w3c/webrtc-encoded-transform#161.

Change-Id: I2c0d8dc97c405ce9ef9b79679cb20f6fcfb4ddbd
Bug: webrtc:14709
aarongable pushed a commit to chromium/chromium that referenced this issue Jun 21, 2023
@palak8669
Add setTimestamp in RTCEncodedAudioFrame behind a flag
e7679f5 
This is in related to the use cases mentioned in w3c/webrtc-encoded-transform#161.

Change-Id: I2c0d8dc97c405ce9ef9b79679cb20f6fcfb4ddbd
Bug: webrtc:14709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4601477
Reviewed-by: Guido Urdaneta <[email protected]>
Commit-Queue: Palak Agarwal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1160669}
@alvestrand
Copy link
Collaborator Author

Closed as the approach suggested in #181 is a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clone() method w3c/webrtc-encoded-transform
1 participant
@alvestrand