Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing chunks other than frames to RTCRtpScriptTransformer should fail #191

Open
docfaraday opened this issue Jun 23, 2023 · 1 comment
Open

Writing chunks other than frames to RTCRtpScriptTransformer should fail #191

docfaraday opened this issue Jun 23, 2023 · 1 comment

Comments

@docfaraday
Copy link

Right now there's no type checking, that needs a fix. Right now, Safari throws TypeError, which seems reasonable.
@youennf
Copy link
Collaborator

youennf commented Jul 5, 2023

The current algorithm is silently ignoring any chunk that is not a frame coming from the paired stream, in step 1 of https://w3c.github.io/webrtc-encoded-transform/#abstract-opdef-writeencodeddata.

I guess we can align Safari to the spec or align the spec to Safari.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@docfaraday @youennf