-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move RTP Timestamp to Metadata and rename #203
Comments
we had #169 for that? Either way, the PR fixes both. |
I thought the same re #169 , but re-reading it before filing the PR it seems to be suggesting that we should try to map the existing I'll add a comment over there too. |
Oh, hmm, maybe I misunderstood #169 after all and this is the same? |
We agree on what needs to be done - thank for pushing it! 💪 |
Currently both RTCEncodedAudioFrame and RTCEncodedVideoFrame have a
timestamp
field directly on the frame defined as the RTP timestamp, and atimestamp
in their Metadata dict defined as the Presentation timestamp (to match WebCodecs). This is quite a confusing situation.As discussed during the April Interim and on #173, it makes sense to move the RTP timestamp to the metadata and rename it
rtpTimestamp
.The text was updated successfully, but these errors were encountered: