Now test for cancellation detection upon entering a gate that is open.

It's important to be consistent on this irrespective of the state of the gate (it's also helpful to users as they don't have to separately check for cancellation, if they're entering the gate anyway).

Author: wadetregaskis

Tests/GateTests/GateTests.swift

@@ -131,31 +131,34 @@ final class GateTests: XCTestCase {
         }
     }
 
-    func testClosedGateEnteredByAlreadyCancelledTask() throws {
-        let gate = Gate(initiallyOpen: false)
+    func testGateEnteredByAlreadyCancelledTask() throws {
+        for initialState in [true, false] {
+            let gate = Gate(initiallyOpen: initialState)
 
-        let passedThroughExpectation = XCTestExpectation(description: "Task should not have passed through the gate.")
-        passedThroughExpectation.isInverted = true
+            let passedThroughExpectation = XCTestExpectation(description: "Task should not have passed through the gate.")
+            passedThroughExpectation.isInverted = true
 
-        let cancelledExpectation = XCTestExpectation(description: "Task should have been cancelled.")
+            let cancelledExpectation = XCTestExpectation(description: "Task should have been cancelled.")
 
-        Task {
-            withUnsafeCurrentTask {
-                $0!.cancel()
-            }
+            Task {
+                withUnsafeCurrentTask {
+                    $0!.cancel()
+                }
 
-            do {
-                try await gate.enter()
-            } catch is CancellationError {
-                cancelledExpectation.fulfill()
-                return
-            }
+                do {
+                    try await gate.enter()
+                } catch is CancellationError {
+                    cancelledExpectation.fulfill()
+                    return
+                }
 
-            passedThroughExpectation.fulfill()
-        }
+                passedThroughExpectation.fulfill()
+            }
 
-        wait(for: [cancelledExpectation, passedThroughExpectation], timeout: 1.0)
+            wait(for: [cancelledExpectation, passedThroughExpectation], timeout: 1.0)
 
-        gate.open() // Just to ensure that opening the gate afterwards doesn't somehow crash.
+            gate.open() // Just to ensure that opening or closing the gate afterwards doesn't somehow crash.
+            gate.close()
+        }
     }
 }