Skip to content

Commit dbffe47

Browse files
committed
Fix breaking change in symbol server
1 parent 26518d4 commit dbffe47

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

CSharpRepl.Services/Configuration.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public sealed class Configuration
4040
public static readonly IReadOnlyCollection<string> SymbolServers =
4141
[
4242
"https://symbols.nuget.org/download/symbols/",
43-
"http://msdl.microsoft.com/download/symbols/"
43+
"https://msdl.microsoft.com/download/symbols/"
4444
];
4545

4646
public HashSet<string> References { get; }

CSharpRepl.Services/SymbolExploration/DebugSymbolLoader.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ private CacheSymbolStore BuildSymbolStore()
5252

5353
foreach (var server in Configuration.SymbolServers)
5454
{
55-
store = new HttpSymbolStore(logger, store, new Uri(server), null);
55+
store = new HttpSymbolStore(logger, store, new Uri(server), accessToken: null);
5656
}
5757

5858
var cacheDirectory = Path.Combine(Configuration.ApplicationDirectory, "symbols");

CSharpRepl.Services/SymbolExploration/SymbolExplorer.cs

+5
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,11 @@ public async Task<SymbolResult> LookupSymbolAtPosition(string text, int position
8484

8585
foreach (var key in debugSymbolLoader.GetSymbolFileNames()) // we'll choose the first pdb we can successfully load. This will skip over e.g. Windows pdb files.
8686
{
87+
if (key.FullPathName.Contains(".ni.pdb"))
88+
{
89+
continue;
90+
}
91+
8792
using SymbolStoreFile symbolFile = await debugSymbolLoader.DownloadSymbolFile(key, CancellationToken.None);
8893

8994
var symbolReader = debugSymbolLoader.ReadPortablePdb(symbolFile);

0 commit comments

Comments
 (0)