Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet icon expanding outside of the "icon box" #76

Open
jamesbiggs opened this issue Aug 7, 2023 · 2 comments
Open

Snippet icon expanding outside of the "icon box" #76

jamesbiggs opened this issue Aug 7, 2023 · 2 comments

Comments

@jamesbiggs
Copy link

image

After upgrading my project to wagtail 5.1, all my uses of the wagtail-generic-chooser have started to look like the above. I'm not noticing this anywhere else so I'm not sure if it's coming from the wagtail package or the wagtail-generic-chooser package. However I'm not seeing any CSS in this package so I'm thinking maybe it's coming from a change in wagtail?

If we can add a width: 95%; somewhere that would apply it to https://github.com/wagtail/wagtail-generic-chooser/blob/main/generic_chooser/templates/generic_chooser/widgets/chooser.html#L15-L17, this seems to fix the issue:
image

@gasman
Copy link
Collaborator

gasman commented Aug 7, 2023

Hi @jamesbiggs - thanks for the report.

I didn't encounter anything like this when updating this package for Wagtail 5.1 last week. Often, CSS bugs on upgrade can be a result of outdated CSS being cached from the previous version - have you tried force-refreshing the page? And if this is on a production site (running under a real webserver), did you run ./manage.py collectstatic after upgrading?

@jamesbiggs
Copy link
Author

Hi @gasman, cheers for the speedy response! 😃 I've done a force-refresh and on my local just ran ./manage.py collectstatic but am still getting this. Same on the prod site, we run collectstatic in our build step, force refresh had no luck either 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants