New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sds: determine required number of acknowledgements based on bloom filter params #2260

Open

adklempner opened this issue Feb 11, 2025 · 0 comments

Member

adklempner commented Feb 11, 2025

Per https://rfc.vac.dev/vac/raw/sds/#review-ack-status :

If a message appears as possibly acknowledged in multiple received bloom filters, the participant MAY mark it as acknowledged based on probabilistic grounds, taking into account the bloom filter size and hash number.

Currently, the number of acknowledgements is hard-coded to 2. It should be based on a function that accepts bloom filter params.

chair28980 added this to Waku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment