Repository navigation
Fix #2171: build OpenSSL from source on Windows - #2172
Merged
Merged
Conversation
Praxis 0.7.3 made OpenSSL a hard dependency on every target. Windows runners have no OpenSSL dev install, so the early-access Windows job fails, the multi-arch manifest job is skipped, and the early-access image stays on the 2026-10-01 build. Enable the openssl crate's vendored feature on Windows only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0189XaWeWPUxirC7mGwNFAGp
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR fixes Windows early-access builds by adding a target-specific, vendored OpenSSL dependency to the server crate, causing OpenSSL to be built from source on Windows while preserving existing Linux and macOS builds; the lockfile is updated accordingly. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
orpiske
marked this pull request as ready for review
October 20, 2026 14:58
orpiske
requested a deployment
to
integration-tests
October 20, 2026 14:58 — with
GitHub Actions
Waiting
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. Windows builds will now use vendored OpenSSL 3.6.3 for cryptographic operations; a flawed or unsuitable library could expose data protected by those operations. Reverting stops future builds from using it, but cannot undo exposure from binaries already deployed.
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Otavio · project thread
Before: the early-access Windows job fails because
openssl-sysfinds no OpenSSL. The multi-arch manifest job is then skipped, soquay.io/wanaku/wanaku-server:early-access(and the Saci worker image built from it) still runs the 2026-10-01 server, without tool enable/disable and other later features.After: Windows builds compile OpenSSL from source, so the Windows job can pass and the early-access tag can move again.
How: a
cfg(windows)dependency onopensslwith thevendoredfeature inserver/Cargo.toml. Feature unification makesopenssl-sysuseopenssl-srcon Windows only. Linux and macOS builds are unchanged (cargo check -p wanaku-server --lockedpasses on Linux).Not verified on Windows yet: PR CI has no Windows job. A dispatch of the early-access workflow on this branch, or after merge, will confirm it.
Closes #2171
Generated by Claude Code
Summary by Sourcery
Make OpenSSL available during Windows server builds to restore successful early-access image publishing.
Bug Fixes:
Build: