Skip to content

Fix #2171: drop Windows from early-access - #2173

Merged
orpiske merged 2 commits into
mainfrom
claude/project-thread-y5v8fv
Oct 20, 2026
Merged

orpiske merged 2 commits into
mainfrom
claude/project-thread-y5v8fv

Conversation

@orpiske

@orpiske orpiske commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Otavio · project thread

Before: the early-access Windows job fails (run 120). The multi-arch manifest job waits on every build job, so it is skipped and quay.io/wanaku/wanaku-server:early-access stays on the 2026-10-01 build.

After: early-access builds Linux and macOS only, so the manifest job can run and move the tag.

How:

  • early-access.yml: remove the windows-2025 matrix entry, both Windows packaging steps, the Unix-only guards, and dist/*.zip from the upload paths. Run JReleaser with --reject-platform=windows-x86_64, because jreleaser.yml (shared with release.yml) still lists the Windows zips.
  • features/evaluator/src/filter.rs: opa_unavailable_is_a_failure uses a 5s timeout. Windows retries a refused connection for about two seconds, so the 1s timeout reported a timeout. This only matters for local Windows test runs now.

The release workflow does not change.

Refs #2171

🤖 Generated with Claude Code

https://claude.ai/code/session_0189XaWeWPUxirC7mGwNFAGp

…indows

Windows retries a refused TCP connection for about two seconds. With the
1s test timeout, opa_unavailable_is_a_failure saw RemoteTimeout instead
of RemoteUnavailable, which failed the early-access Windows job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0189XaWeWPUxirC7mGwNFAGp
@orpiske orpiske self-assigned this Oct 20, 2026
@sourcery-ai

sourcery-ai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR fixes the Windows failure in opa_unavailable_is_a_failure by overriding the test connection timeout from the default 1 second to 5 seconds, allowing the refused TCP connection to resolve as RemoteUnavailable instead of timing out as RemoteTimeout.

File-Level Changes

Change Details Files
Increase the OPA-unavailable test’s connection timeout to accommodate Windows’ slower refused-connection retry behavior.
  • Construct the test connection with a 5-second timeout while retaining the existing endpoint and settings.
  • Leave production code unchanged; the adjustment is isolated to the test setup.
features/evaluator/src/filter.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Oct 20, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

The Windows job keeps the manifest job from running, so the
early-access image tag does not move. Early-access does not need a
Windows build. JReleaser skips the Windows artifacts that jreleaser.yml
still lists for tagged releases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0189XaWeWPUxirC7mGwNFAGp
@orpiske orpiske changed the title Fix #2171: OPA unavailable test times out on Windows Fix #2171: drop Windows from early-access Oct 20, 2026
@sourcery-ai
sourcery-ai Bot dismissed their stale review October 20, 2026 17:13

Sourcery withdrew this approval because the latest commits introduced blocking findings.

@orpiske
orpiske merged commit 44b991f into main Oct 20, 2026
5 of 6 checks passed

This branch is waiting to be deployed

1 waiting deployment
integration-tests — daf15337 Waiting Oct 20, 2026 by orpiske via Dispatch Integration Tests #821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants