Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unofficial working solution for TB91 #44

Open
AlexUkr73 opened this issue Sep 16, 2021 · 22 comments
Open

Unofficial working solution for TB91 #44

AlexUkr73 opened this issue Sep 16, 2021 · 22 comments

Comments

@AlexUkr73
Copy link

Some fixes to work in TB91.
Only showing photos from Local Directory was checked
LdapInfo91.zip

@tidebre67
Copy link

@AlexUkr73 , Alex, great that you taking up this addon to work under v91. I made a short test, unfortunately photos from the addressbook are not shown and the setting symbol in the addon manager is in black. Currently TB 91.1.0 (64 bit) is installed.

@tidebre67
Copy link

@AlexUkr73 : Alex, i use this addons since v78, before i used Display contact photos made by Samuel Müller.
Due to the fact that i only need the pickup function from the local addressbook and do not need
the LDAP function this addon was perfect for me.
Sammuell (display contact photos) did not respond of request to update this addon. In case you
also need the addreesbook function only, it may be that you will be interested in this addon too.
I have absolutely no skills in programming but perhaps the re-writting may be a bit easier
compared to Awesome ldapInfoShow.

@AlexUkr73
Copy link
Author

Update:
solution above does not work on clean systems - only on ones with previously installed addon.
Addon Settings don't save (e.g. directory for Local photos)
As workaround it is possible to define it in Config Editor manually:

  • access Preferences -> Config Editor (at the bottom)
  • modify "extensions.ldapinfoshow.local_pic_dir" setting - define path to you Photos directory as string value (click on String radiobutoon), e.g. C:\Mail_foto

@AlexUkr73
Copy link
Author

AlexUkr73 commented Sep 18, 2021

tidebre67: Alex, i use this addons since v78, before i used Display contact photos made by Samuel Müller.

I've tried to make this addon working at first but without any success.

I have absolutely no skills in programming but perhaps the re-writting may be a bit easier
compared to Awesome ldapInfoShow.

I'm also not mastered in programming, just managed to make addon working.
May be after some experience with ldapInfoShow it will be good idea to try with 'Display contact photos' re-writing.

@tidebre67
Copy link

Alex, at first it was a bit strange for me as i installed ldapinfoshow v91 over v78, therefore no clean installation. Finally i found that you're talking about a directory. i do not have the photos saved in a directory. In previous version photos were picked direct from the address book. guess that is the difference and therefore photos are not shown in my mails.

@AlexUkr73
Copy link
Author

tidebre67
Ok, photos from Address Book are not displayed as I had to comment/disable some functions to make addon at least start without errors.
Suppose Address Book functionality was affected.
I'll check this and try to fix.
On this moment I don't have any solution.

@tidebre67
Copy link

AlexUkr73,
noted yr comment, tks for that.
If you are interested to get some help or assistance to improve this addon it might be a good idea to get in contact
with John Bieling (Thunderbird Add-On Coordinator and Support Engineer) of MZLA (jobisoft in github).
But that is of course upto you.

@AlexUkr73
Copy link
Author

tidebre67
Seems I've managed to fix issue with AddressBook - could you check this on this beta, please
LDAP91_2.zip
?

@tidebre67
Copy link

AlexUkr73,
excellent work. Works absolutely well for me..
Tks for updating this addon.
Krgds Thomas

@gruniversal
Copy link

Thank you, also works for me.

@AlexUkr73
Copy link
Author

AlexUkr73 commented Oct 25, 2021

Finally, all found errors are fixed.
(except loading photo from LDAP - I can not test this /no LDAP available/ and does not have any clue how it works)

ldapInfoShow91_3.zip

F i x e s :
1 - Loading photo from AddressBook card
2 - Detailed contact info popup is less ugly
3 - Compose window displays LAST entered contact in To/CC/BCC fields (buggy - works only for manually entered e-mail)
4 - Correct addon unloading (addon will not eat all your RAM and scare your cat)

@jobisoft
Copy link

jobisoft commented Oct 26, 2021

Is the original author has not updated this add-on since September 2018. Is @AlexUkr73 interested in creating a new add-on based on his work and make it available on ATN (addons.thunderbird.net)?

(Or try to get the original author to add @AlexUkr73 as owner to his add-on on ATN),

@AlexUkr73
Copy link
Author

AlexUkr73 commented Nov 1, 2021

Is @AlexUkr73 interested in creating a new add-on
No, I'm not interested.

ldapInfoShow91_5.zip

( 04/Nov/2021 - addon re-attached - improvements in compose window)

F i x e s :

  • Recipients photo in Compose window;
  • Detailed contact info popup.

@jobisoft
Copy link

jobisoft commented Nov 1, 2021

s @AlexUkr73 interested in creating a new add-on
No, I'm not interested.

Did not expect that. Would you mind giving me a hint why? You could help a lot more users, when this add-on is available on ATN again.

Thanks for your work on this.

@Hayasa
Copy link

Hayasa commented Jan 3, 2022

Dear @AlexUkr73, thank you for your work. Are you planning to fix the functionality for working with LDAP?

@AlexUkr73
Copy link
Author

@Hayasa - I don't plan to fix LDAP as don't use it and don't have possibilities to test this.
I even don't know how it works at all.
Anyway, I'll be glad to help (if I can) if someone tries to fix this.

@tidebre67
Copy link

@AlexUkr73
short question, when composing, reply and forwarding only a avatar is shown in the header but the not the photo.
i tried various changes in the settings but i was not able to get it working. Any idea what has to ben done in the settings?

@AlexUkr73
Copy link
Author

@tidebre67
Seems changes in setting do not saved.
Do you have photos in header when just viewing message ?

You can modify addon setting directly from TB config editor (Preferences > General > Config Editor button on bottom)
Use 'ldapinfo' search string to filter addon's options
thunderbird_config

@AlexUkr73
Copy link
Author

What about displaying photos in composition - the photo of last email in focused TO/CC/BCC field is displayed
compose1

To display desired email photo:
1 - click on email
2 - click in area marked with red rectangle (somewhere below To: or Cc: label text)
compose2

I don't know how to make them display automatically (only by clicking on email), so left this as is.

@tidebre67
Copy link

@AlexUkr73 , mny thks for yr reponse. The settings are okay.
Your last info is very helpful. In case you have any automatic BCC when opening a new window then it is not working,
In case you open a new window wihout BCC it's working and i can add BCC, the photo will remain .

image

image

As i now know what the problem is, i delete the Bcc first and add the Bcc later.

@ferta
Copy link

ferta commented May 31, 2022

31/05/2022 - addon re-attached
ldapInfoShow91_6.zip

Fix:

  • show photo from LDAP

@Hayasa
Copy link

Hayasa commented Jun 10, 2022

31/05/2022 - addon re-attached ldapInfoShow91_6.zip

Fix:

  • show photo from LDAP

Hello ferta. not work with openldap. Can you present, how to work it for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants