Disable replica DB config (#357)

Author: deer-wmde

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 Tags have the format: `<MediaWiki core version>-<PHP Version>-<date>-<build number>`
 
+## 1.39-7.4-20230524-0
+- Add condition for skipping Db replica config in case replica hostname is not set (empty string)
+
 ## 1.39-7.4-20230522-0
 - Allow email-confirmed users to add external urls (T327752)
 

dist-persist/wbstack/src/Settings/LocalSettings.php

@@ -120,7 +120,8 @@
 // For example schema generation or localization cache reload
 // WBS_DOMAIN=maint php ./w/maintenance/update.php --schema sql.sql --quick
 // As in these contexts there is often no replica.... and thus one would fail...
-if( !$wwDomainIsMaintenance ){
+// Also: skip the config if host name is empty. Useful in case replication breaks and we want to disable it.
+if( !$wwDomainIsMaintenance && !empty(getenv('MW_DB_SERVER_REPLICA'))){
     $wgDBservers[] = [
         'host' => getenv('MW_DB_SERVER_REPLICA'),
         'dbname' => $wgDBname,

dist/wbstack/src/Settings/LocalSettings.php

@@ -120,7 +120,8 @@
 // For example schema generation or localization cache reload
 // WBS_DOMAIN=maint php ./w/maintenance/update.php --schema sql.sql --quick
 // As in these contexts there is often no replica.... and thus one would fail...
-if( !$wwDomainIsMaintenance ){
+// Also: skip the config if host name is empty. Useful in case replication breaks and we want to disable it.
+if( !$wwDomainIsMaintenance && !empty(getenv('MW_DB_SERVER_REPLICA'))){
     $wgDBservers[] = [
         'host' => getenv('MW_DB_SERVER_REPLICA'),
         'dbname' => $wgDBname,