From 522078759921baf9b93e2e018dd4f10eaa51d185 Mon Sep 17 00:00:00 2001 From: fidanf Date: Mon, 18 Aug 2025 22:43:42 +0200 Subject: [PATCH 1/2] fix: Adding primary group conditional + update syntax to latest Ansible versions --- tasks/manage.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tasks/manage.yml b/tasks/manage.yml index 7bad8b1..8a040b0 100644 --- a/tasks/manage.yml +++ b/tasks/manage.yml @@ -4,17 +4,17 @@ ansible.builtin.group: name: "{{ users_group }}" state: present - when: users_group is defined and users_group + when: users_group is defined and users_group | length | bool - name: Adding secondary groups ansible.builtin.group: name: "{{ item }}" state: present - with_items: "{{ users_groups | default([]) }}" + loop: "{{ users_groups | default([]) }}" - name: Configure users - include_tasks: manage_user.yml - with_items: "{{ users }}" + ansible.builtin.include_tasks: manage_user.yml + loop: "{{ users }}" loop_control: loop_var: user @@ -23,4 +23,4 @@ name: "{{ item.username if item.username is defined else item }}" state: absent remove: "{{ item.remove if item.remove is defined else omit }}" - with_items: "{{ users_remove }}" + loop: "{{ users_remove }}" From 321e8e76bcb66226112841b80765c612759d7bc5 Mon Sep 17 00:00:00 2001 From: fidanf Date: Mon, 18 Aug 2025 22:46:17 +0200 Subject: [PATCH 2/2] fix: set default value and type for users_group --- defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/main.yml b/defaults/main.yml index 7c3782e..597522f 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -49,7 +49,7 @@ users_home: /home # create user's home directory users_home_create: yes # default user's primary group for users -users_group: +users_group: "" # default user's secondary groups users_groups: [] # default user's home directory permissions