Merge pull request #1859 from weaviate/gkampitakis/rename_sorting_opt

chore: rename started_at_asc for sorting backup list

Author: dirkkul

integration/test_backup_v4.py

@@ -626,7 +626,7 @@ def test_list_backup_ascending_order(client: weaviate.WeaviateClient, request: S
     resp = client.backup.create(backup_id=backup_id, backend=BACKEND)
     assert resp.status == BackupStatus.STARTED
 
-    backups = client.backup.list_backups(backend=BACKEND, sort_ascending=True)
+    backups = client.backup.list_backups(backend=BACKEND, sort_by_starting_time_asc=True)
     assert backup_id.lower() in [b.backup_id.lower() for b in backups]
 
     assert sorted(backups, key=lambda b: b.started_at or b.backup_id) == backups

weaviate/backup/async_.pyi

@@ -56,5 +56,5 @@ class _BackupAsync(_BackupExecutor[ConnectionAsync]):
         backup_location: Optional[BackupLocationType] = None,
     ) -> bool: ...
     async def list_backups(
-        self, backend: BackupStorage, sort_ascending: Optional[bool] = None
+        self, backend: BackupStorage, sort_by_starting_time_asc: Optional[bool] = None
     ) -> List[BackupListReturn]: ...

weaviate/backup/executor.py

@@ -475,12 +475,12 @@ def resp(res: Response) -> bool:
         )
 
     def list_backups(
-        self, backend: BackupStorage, sort_ascending: Optional[bool] = None
+        self, backend: BackupStorage, sort_by_starting_time_asc: Optional[bool] = None
     ) -> executor.Result[List[BackupListReturn]]:
         _, backend = _get_and_validate_get_status(backend=backend, backup_id="dummy")
         path = f"/backups/{backend.value}"
         params = {}
-        if sort_ascending:
+        if sort_by_starting_time_asc:
             params["order"] = "asc"
 
         def resp(res: Response) -> List[BackupListReturn]:

weaviate/backup/sync.pyi

@@ -56,5 +56,5 @@ class _Backup(_BackupExecutor[ConnectionSync]):
         backup_location: Optional[BackupLocationType] = None,
     ) -> bool: ...
     def list_backups(
-        self, backend: BackupStorage, sort_ascending: Optional[bool] = None
+        self, backend: BackupStorage, sort_by_starting_time_asc: Optional[bool] = None
     ) -> List[BackupListReturn]: ...