Skip to content

Commit b3a1d4b

Browse files
committed
chore: use more descriptive name
1 parent 5351c58 commit b3a1d4b

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

integration/test_backup_v4.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -626,7 +626,7 @@ def test_list_backup_ascending_order(client: weaviate.WeaviateClient, request: S
626626
resp = client.backup.create(backup_id=backup_id, backend=BACKEND)
627627
assert resp.status == BackupStatus.STARTED
628628

629-
backups = client.backup.list_backups(backend=BACKEND, started_at_asc=True)
629+
backups = client.backup.list_backups(backend=BACKEND, sort_by_starting_time_asc=True)
630630
assert backup_id.lower() in [b.backup_id.lower() for b in backups]
631631

632632
assert sorted(backups, key=lambda b: b.started_at or b.backup_id) == backups

weaviate/backup/async_.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ class _BackupAsync(_BackupExecutor[ConnectionAsync]):
5656
backup_location: Optional[BackupLocationType] = None,
5757
) -> bool: ...
5858
async def list_backups(
59-
self, backend: BackupStorage, started_at_asc: Optional[bool] = None
59+
self, backend: BackupStorage, sort_by_starting_time_asc: Optional[bool] = None
6060
) -> List[BackupListReturn]: ...

weaviate/backup/executor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -475,12 +475,12 @@ def resp(res: Response) -> bool:
475475
)
476476

477477
def list_backups(
478-
self, backend: BackupStorage, started_at_asc: Optional[bool] = None
478+
self, backend: BackupStorage, sort_by_starting_time_asc: Optional[bool] = None
479479
) -> executor.Result[List[BackupListReturn]]:
480480
_, backend = _get_and_validate_get_status(backend=backend, backup_id="dummy")
481481
path = f"/backups/{backend.value}"
482482
params = {}
483-
if started_at_asc:
483+
if sort_by_starting_time_asc:
484484
params["order"] = "asc"
485485

486486
def resp(res: Response) -> List[BackupListReturn]:

weaviate/backup/sync.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ class _Backup(_BackupExecutor[ConnectionSync]):
5656
backup_location: Optional[BackupLocationType] = None,
5757
) -> bool: ...
5858
def list_backups(
59-
self, backend: BackupStorage, started_at_asc: Optional[bool] = None
59+
self, backend: BackupStorage, sort_by_starting_time_asc: Optional[bool] = None
6060
) -> List[BackupListReturn]: ...

0 commit comments

Comments
 (0)