Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: HMR does not work after making modifications when there is a compilation error. #4682

Closed
HuGtoX opened this issue Mar 1, 2025 · 4 comments

Comments

@HuGtoX
Copy link

HuGtoX commented Mar 1, 2025

Version

System:
    OS: Windows 11 22000.2538
    CPU: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 11.52 GB / 15.9 GB
  Browsers:
    Edge: Chromium (133.0.3065.82)
    Internet Explorer: 11.0.19041.4355
  npmPackages:
    @rsbuild/core: ^1.2.8 => 1.2.13
    @rsbuild/plugin-react: ^1.1.0 => 1.1.1

Details

Since version rsbuild/[email protected], HRM does not work after making modifications when there is a compilation error.

Reproduce link

https://codesandbox.io/p/devbox/psmm3t

Reproduce Steps

  1. npm create rsbuild@latest
  2. npm i
  3. Modify the file to test the HMR (Work properly)
  4. Try to modify app.tsx into an incorrect format
  5. HMR is not working
@chenjiahan
Copy link
Member

This is a regression introduced in Rspack v1.2.6.

I have released @rsbuild/core v.1.2.14 to downgrade Rspack to v1.2.5.

See: https://github.com/web-infra-dev/rsbuild/releases/tag/v1.2.14

@HuGtoX HuGtoX changed the title [Bug]: HRM does not work after making modifications when there is a compilation error. [Bug]: HMR does not work after making modifications when there is a compilation error. Mar 1, 2025
@KingrrrYuri
Copy link

KingrrrYuri commented Mar 1, 2025

This is a regression introduced in Rspack v1.2.6.

I have released @rsbuild/core v.1.2.14 to downgrade Rspack to v1.2.5.

See: https://github.com/web-infra-dev/rsbuild/releases/tag/v1.2.14

hello, when I change @rsbuild/core, if I should change the version of it's plugins like plugin-react or plugin-svgr also?

@chenjiahan
Copy link
Member

No, the plugins does not need to be upgraded

@chenjiahan
Copy link
Member

This has been fixed by web-infra-dev/rspack#9482.

We will release a new Rspack patch today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants