fix: ci error

Author: SyMind

.cargo/config.toml

@@ -43,9 +43,7 @@ rustflags = ["-C", "link-args=-Wl,-undefined,dynamic_lookup,-no_fixup_chains,-al
 
 # To be able to run unit tests on Linux, support compilation to 'x86_64-unknown-linux-gnu'.
 [target.'cfg(target_os = "linux")']
-rustflags = [
-"-C", "link-args=-Wl,--warn-unresolved-symbols"
-]
+rustflags = ["-C", "link-args=-Wl,--warn-unresolved-symbols"]
 
 # To be able to run unit tests on Windows, support compilation to 'x86_64-pc-windows-msvc'.
 # Use Hybrid CRT to reduce the size of the binary (Coming by default with Windows 10 and later versions).

.github/workflows/ci.yml

@@ -21,12 +21,6 @@ on:
     tags-ignore:
       - "**"
 
-env:
-  # Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness.
-  # https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11
-  CARGO_INCREMENTAL: 0
-  TMPDIR: target/tmpdir
-
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}
   cancel-in-progress: ${{ github.ref_name != 'main' }}
@@ -226,7 +220,7 @@ jobs:
         uses: ./.github/actions/pnpm-cache
         with:
           run-install: false
-      
+
       - name: Run Cargo Check
         run: cargo check --workspace --all-targets --locked # Not using --release because it uses too much cache, and is also slow.
 

Cargo.lock

@@ -21,7 +21,6 @@ anyhow = { workspace = true }
 chrono = "0.4"
 easy-error = "1.0.0"
 either = "1"
-fxhash = "0.2.1"
 hex = "0.4.3"
 indoc = { workspace = true }
 lazy_static = { workspace = true }

crates/next-custom-transforms/Cargo.toml

@@ -61,8 +61,6 @@ serde_json         = { workspace = true }
 swc_core           = { workspace = true, default-features = false, features = ["ecma_transforms_react"] }
 tokio              = { workspace = true, features = ["rt", "rt-multi-thread", "macros", "test-util", "parking_lot"] }
 
-
-json                                   = { workspace = true }
 rspack_loader_lightningcss             = { workspace = true }
 rspack_loader_preact_refresh           = { workspace = true }
 rspack_loader_react_refresh            = { workspace = true }

crates/node_binding/Cargo.toml

@@ -10,8 +10,6 @@ version     = "0.2.0"
 async-recursion          = { workspace = true }
 async-trait              = { workspace = true }
 base64-simd              = { version = "0.8.0", features = ["alloc"] }
-cow-utils                = { workspace = true }
-dashmap                  = { workspace = true }
 futures                  = { workspace = true }
 json                     = { workspace = true }
 lazy-regex               = "3.4.1"

crates/rspack_loader_next_app/Cargo.toml

@@ -8,33 +8,26 @@ version     = "0.2.0"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-rspack_cacheable      = { workspace = true }
-rspack_collections    = { workspace = true }
-rspack_core           = { workspace = true }
-rspack_error          = { workspace = true }
-rspack_hook           = { workspace = true }
-rspack_loader_runner  = { workspace = true }
-rspack_paths          = { workspace = true }
-rspack_plugin_runtime = { workspace = true }
-rspack_util           = { workspace = true }
+rspack_collections = { workspace = true }
+rspack_core        = { workspace = true }
+rspack_error       = { workspace = true }
+rspack_hook        = { workspace = true }
+rspack_paths       = { workspace = true }
+rspack_util        = { workspace = true }
 
 async-trait              = { workspace = true }
 derive_more              = { workspace = true }
 form_urlencoded          = "1.2.1"
 futures                  = { workspace = true }
-hashlink                 = { workspace = true }
 indexmap                 = { workspace = true }
-itertools                = { workspace = true }
 lazy-regex               = "3.4.1"
 querystring              = { version = "1.1.0" }
 regex                    = { workspace = true }
 rspack_plugin_javascript = { workspace = true }
 rustc-hash               = { workspace = true }
 serde                    = { workspace = true }
 serde_json               = { workspace = true }
-serde_urlencoded         = "0.7.1"
 sugar_path               = { workspace = true }
-tokio                    = { workspace = true, features = ["rt"] }
 tracing                  = { workspace = true }
 
 [package.metadata.cargo-shear]

crates/rspack_plugin_next_flight_client_entry/Cargo.toml

@@ -930,10 +930,10 @@ impl FlightClientEntryPlugin {
         }
         visited_entry.insert(request);
 
-        let Some(connction) = module_graph.connection_by_dependency_id(dependency_id) else {
+        let Some(connection) = module_graph.connection_by_dependency_id(dependency_id) else {
           continue;
         };
-        let Some(resolved_module) = module_graph.module_by_identifier(&connction.resolved_module)
+        let Some(resolved_module) = module_graph.module_by_identifier(&connection.resolved_module)
         else {
           continue;
         };

crates/rspack_plugin_next_flight_client_entry/src/lib.rs

@@ -47,6 +47,7 @@ export class Dependency {
 		if (binding) {
 			return binding.request;
 		}
+		return undefined;
 	}
 
 	get critical(): boolean {

packages/rspack/src/Dependency.ts

@@ -1,6 +1,6 @@
 import {
 	BuiltinPluginName,
-	RawFlightClientEntryPluginOptions
+	type RawFlightClientEntryPluginOptions
 } from "@rspack/binding";
 
 import { create } from "./base";