From f34377ae1fd1d74e1280b56beb3a33c38f80691d Mon Sep 17 00:00:00 2001 From: jinrui Date: Fri, 14 Feb 2025 17:42:25 +0800 Subject: [PATCH] fix: persistent cache remove non-existent modules from make_failed_module (#9309) fix: cache remove non-existent modules from make_failed_module --- .../rspack_core/src/cache/persistent/occasion/make/mod.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs b/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs index 221faa83e62f..08eb6eddb76e 100644 --- a/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs +++ b/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs @@ -90,6 +90,12 @@ impl MakeOccasion { artifact.build_dependencies = build_dep; artifact.reset_dependencies_incremental_info(); + // TODO remove it after all of module are cacheable + let mut make_failed_module = std::mem::take(&mut artifact.make_failed_module); + let mg = artifact.get_module_graph_mut(); + make_failed_module.retain(|module_id| mg.module_by_identifier(module_id).is_some()); + artifact.make_failed_module = make_failed_module; + Ok(artifact) } }