Skip to content

Commit 226a372

Browse files
josepharharchromium-wpt-export-bot
josepharhar
authored and
chromium-wpt-export-bot
committed
Remove testdriver from some StylableSelect WPTs
testdriver is not supported in reftests: #13183 #46152 I worked around using testdriver in some of these tests, but others really need to use testdriver so I put a comment in them saying that the test probably won't work until testdriver in reftests is supported. These tests are still worth keeping not only for future support but because they work properly when run with run_web_tests.py. Bug: 40146374 Change-Id: I73d02e5ead3c2dd4c84300e78f6502357dd7524b
1 parent e40e7e0 commit 226a372

8 files changed

+28
-38
lines changed

‎html/semantics/forms/the-select-element/stylable-select/native-popup-with-datalist-ref.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111

1212
<script>
1313
(async () => {
14+
// This test needs test_driver.bless() in order to get user activation for
15+
// showPicker, but likely won't work properly until this bug is fixed:
16+
// https://github.com/web-platform-tests/wpt/issues/13183
1417
await test_driver.click(document.querySelector('select'));
1518
document.documentElement.classList.remove('reftest-wait');
1619
})();

‎html/semantics/forms/the-select-element/stylable-select/native-popup-with-datalist.tentative.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919

2020
<script>
2121
(async () => {
22+
// This test needs test_driver.bless() in order to get user activation for
23+
// showPicker, but likely won't work properly until this bug is fixed:
24+
// https://github.com/web-platform-tests/wpt/issues/13183
2225
await test_driver.click(document.querySelector('select'));
2326
document.documentElement.classList.remove('reftest-wait');
2427
})();

‎html/semantics/forms/the-select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414

1515
<script>
1616
(async () => {
17+
// This test needs test_driver.bless() in order to get user activation for
18+
// showPicker, but likely won't work properly until this bug is fixed:
19+
// https://github.com/web-platform-tests/wpt/issues/13183
1720
await test_driver.bless();
1821
document.querySelector('select').showPicker();
1922
document.documentElement.classList.remove('reftest-wait');

‎html/semantics/forms/the-select-element/stylable-select/select-appearance-dark-mode.tentative.html

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
<!DOCTYPE html>
2-
<html class=reftest-wait>
32
<link rel=author href="mailto:[email protected]">
43
<link rel=help href="https://github.com/whatwg/html/issues/9799">
54
<link rel=match href="select-appearance-dark-mode-ref.html">
6-
<script src="/resources/testdriver.js"></script>
7-
<script src="/resources/testdriver-vendor.js"></script>
85

96
<style>
107
:root {
@@ -13,14 +10,12 @@
1310
</style>
1411

1512
<select style="appearance:base-select">
16-
<option>one</option>
17-
<option>two</option>
13+
<datalist>
14+
<option>one</option>
15+
<option>two</option>
16+
</datalist>
1817
</select>
1918

2019
<script>
21-
(async () => {
22-
await test_driver.bless();
23-
document.querySelector('select').showPicker();
24-
document.documentElement.classList.remove('reftest-wait');
25-
})();
20+
document.querySelector('datalist').showPopover();
2621
</script>

‎html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
<!DOCTYPE html>
2-
<html class=reftest-wait>
32
<link rel=author href="mailto:[email protected]">
43
<link rel=help href="https://github.com/whatwg/html/issues/9799">
54
<link rel=match href="select-appearance-no-button-no-datalist-ref.html">
6-
<script src="/resources/testdriver.js"></script>
7-
<script src="/resources/testdriver-vendor.js"></script>
85

96
<select style="appearance:base-select">
107
<datalist>
@@ -14,9 +11,5 @@
1411
</select>
1512

1613
<script>
17-
(async () => {
18-
await test_driver.bless();
19-
document.querySelector('select').showPicker();
20-
document.documentElement.classList.remove('reftest-wait');
21-
})();
14+
document.querySelector('datalist').showPopover();
2215
</script>

‎html/semantics/forms/the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313

1414
<script>
1515
(async () => {
16+
// This test needs test_driver.bless() in order to get user activation for
17+
// showPicker, but likely won't work properly until this bug is fixed:
18+
// https://github.com/web-platform-tests/wpt/issues/13183
1619
await test_driver.bless();
1720
document.querySelector('select').showPicker();
1821
document.documentElement.classList.remove('reftest-wait');

‎html/semantics/forms/the-select-element/stylable-select/select-appearance-writing-mode-vertical-lr.tentative.html

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
<!DOCTYPE html>
2-
<html class=reftest-wait>
32
<link rel=author href="mailto:[email protected]">
43
<link rel=help href="https://github.com/whatwg/html/issues/9799">
54
<link rel=match href="select-appearance-writing-mode-vertical-lr-ref.html">
6-
<script src="/resources/testdriver.js"></script>
7-
<script src="/resources/testdriver-vendor.js"></script>
85

96
<style>
107
html {
@@ -16,14 +13,12 @@
1613
</style>
1714

1815
<select>
19-
<option>one</option>
20-
<option>two</option>
16+
<datalist>
17+
<option>one</option>
18+
<option>two</option>
19+
</datalist>
2120
</select>
2221

2322
<script>
24-
(async () => {
25-
await test_driver.bless();
26-
document.querySelector('select').showPicker();
27-
document.documentElement.classList.remove('reftest-wait');
28-
})();
23+
document.querySelector('datalist').showPopover();
2924
</script>

‎html/semantics/forms/the-select-element/stylable-select/select-appearance-writing-mode-vertical-rl.tentative.html

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
<!DOCTYPE html>
2-
<html class=reftest-wait>
32
<link rel=author href="mailto:[email protected]">
43
<link rel=help href="https://github.com/whatwg/html/issues/9799">
54
<link rel=match href="select-appearance-writing-mode-vertical-rl-ref.html">
6-
<script src="/resources/testdriver.js"></script>
7-
<script src="/resources/testdriver-vendor.js"></script>
85

96
<style>
107
html {
@@ -16,14 +13,12 @@
1613
</style>
1714

1815
<select>
19-
<option>one</option>
20-
<option>two</option>
16+
<datalist>
17+
<option>one</option>
18+
<option>two</option>
19+
</datalist>
2120
</select>
2221

2322
<script>
24-
(async () => {
25-
await test_driver.bless();
26-
document.querySelector('select').showPicker();
27-
document.documentElement.classList.remove('reftest-wait');
28-
})();
23+
document.querySelector('datalist').showPopover();
2924
</script>

0 commit comments

Comments
 (0)