Funnel angle value updates in SVGAngle through NewValueSpecifiedUnits

Fredrik Söderquist · chromium-wpt-export-bot · commit 9c10ca38b25c · 2024-11-18T17:33:03.000-08:00
Refactor/structure the code so that all cases[*] that set the `value_in_specified_units_` field does so using NewValueSpecifiedUnits. This makes it easier to guarantee that the value the orient type enum is only updated in one place, and that updating it isn't forgotten. Factor out the conversion from one angle unit to another into a helper, to facilitate this. This fixes an issue where the 'valueInSpecifiedUnits' setter didn't update the orient type. Export the test svg/dom/SVGMarkerElement-orientType-synchronization.html to WPT and add an additional case that tests the above. [*] Code-paths that reset said field when the orient type changes still (re)set the value themselves. Fixed: 378120437 Change-Id: I59845590f60d1edbf022a71103d3c6fb3a21aec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6023025 Reviewed-by: Philip Rogers <pdr@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1384659}
diff --git a/svg/painting/scripted/SVGMarkerElement-orientType-synchronization.html b/svg/painting/scripted/SVGMarkerElement-orientType-synchronization.html
@@ -0,0 +1,29 @@
+<!DOCTYPE html>
+<title>SVGMarkerElement.orientType synchronization</title>
+<link rel="help" href="https://svgwg.org/svg2-draft/painting.html#InterfaceSVGMarkerElement">
+<link rel="help" href="https://svgwg.org/svg2-draft/types.html#InterfaceSVGAngle">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script>
+test(function() {
+  const marker = document.createElementNS('http://www.w3.org/2000/svg', 'marker');
+  assert_equals(marker.orientType.baseVal, SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE, 'initial');
+
+  marker.orientType.baseVal = SVGMarkerElement.SVG_MARKER_ORIENT_AUTO;
+  assert_equals(marker.getAttribute('orient'), 'auto');
+  assert_equals(marker.orientType.baseVal, SVGMarkerElement.SVG_MARKER_ORIENT_AUTO, `to 'auto'`);
+}, `${document.title}, setting orientType to 'auto'`);
+
+test(function() {
+  const marker = document.createElementNS('http://www.w3.org/2000/svg', 'marker');
+  assert_false(marker.hasAttribute('orient'));
+
+  marker.setOrientToAuto();
+  assert_equals(marker.getAttribute('orient'), 'auto');
+
+  marker.orientAngle.baseVal.valueInSpecifiedUnits = 1;
+  assert_true(marker.hasAttribute('orient'));
+  assert_equals(marker.getAttribute('orient'), '1');
+  assert_equals(marker.orientType.baseVal, SVGMarkerElement.SVG_MARKER_ORIENT_ANGLE);
+}, `${document.title}, setting orientAngle using valueInSpecifiedUnits`);
+</script>
