[compression-dictionary] Align crossorigin handling with the spec PR.

fred-wang · chromium-wpt-export-bot · commit babeec899751 · 2026-07-16T17:53:57.000-07:00
Per whatwg/html#11620, if crossorigin is "No Cors" we should default to Anonymous. Currently, Chromium departs from the spec and always forces request's mode to "cors" and request's credentials to "omit". This CL aligns Chromium's behavior on the spec PR under a runtime flag and adds corresponding WPT test. Bug: 522338661, 40255884 Change-Id: I30835aebc9df79b59e74747b0729efbc6df69457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8098207 Reviewed-by: Patrick Meenan <pmeenan@chromium.org> Commit-Queue: Frédéric Wang Nélar <fwang@igalia.com> Cr-Commit-Position: refs/heads/main@{#1663435}
diff --git a/fetch/compression-dictionary/dictionary-fetch-with-link-element-crossorigin.tentative.https.html b/fetch/compression-dictionary/dictionary-fetch-with-link-element-crossorigin.tentative.https.html
@@ -0,0 +1,74 @@
+<!DOCTYPE html>
+<title>compression-dictionary</title>
+<meta name="timeout" content="long"/>
+<link rel="help" href="http://github.com/whatwg/html/pull/11620">
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="/service-workers/service-worker/resources/test-helpers.sub.js"></script>
+<script src="./resources/compression-dictionary-util.sub.js"></script>
+<script>
+let frame;
+
+// Set up the service worker and the frame.
+promise_test(t => {
+    const kScope = 'resources/empty.https.html';
+    const kScript = 'resources/fetch-options-worker.js';
+    return service_worker_unregister_and_register(t, kScript, kScope)
+      .then(registration => {
+          add_completion_callback(() => {
+              registration.unregister();
+            });
+
+          return wait_for_state(t, registration.installing, 'activated');
+        })
+      .then(() => {
+          return with_iframe(kScope);
+        })
+      .then(f => {
+          frame = f;
+          add_completion_callback(() => { f.remove(); });
+        });
+  }, 'Initialize global state');
+
+compression_dictionary_promise_test(async t => {
+  await new Promise((resolve, reject) => {
+      let node = frame.contentWindow.document.createElement("link");
+      node.rel = "compression-dictionary";
+      node.onload = resolve;
+      node.onerror = reject;
+      node.href = "dummy?mode=cors&credentials=same-origin";
+      frame.contentWindow.document.body.appendChild(node);
+  }).catch(() => {
+      assert_unreached("Fetch errored.");
+  });
+}, 'HTMLLinkElement rel=compression-dictionary');
+
+compression_dictionary_promise_test(async t => {
+  await new Promise((resolve, reject) => {
+      let node = frame.contentWindow.document.createElement("link");
+      node.rel = "compression-dictionary";
+      node.onload = resolve;
+      node.onerror = reject;
+      node.crossOrigin = "anonymous";
+      node.href = "dummy?mode=cors&credentials=same-origin";
+      frame.contentWindow.document.body.appendChild(node);
+  }).catch(() => {
+      assert_unreached("Fetch errored.");
+  });
+}, 'HTMLLinkElement rel=compression-dictionary crossorigin=anonymous');
+
+compression_dictionary_promise_test(async t => {
+  await new Promise((resolve, reject) => {
+      let node = frame.contentWindow.document.createElement("link");
+      node.rel = "compression-dictionary";
+      node.onload = resolve;
+      node.onerror = reject;
+      node.crossOrigin = "use-credentials";
+      node.href = "dummy?mode=cors&credentials=include";
+      frame.contentWindow.document.body.appendChild(node);
+  }).catch(() => {
+      assert_unreached("Fetch errored.");
+  });
+}, 'HTMLLinkElement rel=compression-dictionary crossorigin=use-credentials');
+
+</script>
diff --git a/fetch/compression-dictionary/resources/dummy b/fetch/compression-dictionary/resources/dummy
diff --git a/fetch/compression-dictionary/resources/empty.https.html b/fetch/compression-dictionary/resources/empty.https.html
@@ -0,0 +1 @@
+<!DOCTYPE html>
diff --git a/fetch/compression-dictionary/resources/fetch-options-worker.js b/fetch/compression-dictionary/resources/fetch-options-worker.js
@@ -0,0 +1,13 @@
+self.addEventListener('fetch', function(event) {
+  if (event.request.url.includes('dummy')) {
+    const params = new URL(event.request.url).searchParams;
+    const credentials = params.get("credentials");
+    const mode = params.get("mode");
+    if ((!mode || mode == event.request.mode) &&
+        (!credentials || credentials == event.request.credentials)) {
+      event.respondWith(fetch(event.request));
+    } else {
+      event.respondWith(Response.error());
+    }
+  }
+});
