Skip to content

Commit bfa8deb

Browse files
Require ::picker(select) appearance:base-select opt-in
This patch requires that not only appearance:base-select be applied to <select> to make the popup be a popover, but also for appearance:base-select to be applied to select::picker(select). This is being discussed here: w3c/csswg-drafts#10440 Change-Id: Ib089a9f8a4c0bea30d2f4fb9da1df185f4272db0
1 parent ab72b1d commit bfa8deb

6 files changed

+21
-6
lines changed

html/semantics/forms/the-select-element/stylable-select/select-accessibility-minimum-target-size.tentative.html

+7-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,13 @@
77
<script src="/resources/testdriver.js"></script>
88
<script src="/resources/testdriver-vendor.js"></script>
99

10-
<select style="appearance:base-select">
10+
<style>
11+
select, select::picker(select) {
12+
appearance: base-select;
13+
}
14+
</style>
15+
16+
<select>
1117
<option></option>
1218
</select>
1319

html/semantics/forms/the-select-element/stylable-select/select-fallback-datalist-animations.tentative.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<script src="/resources/testdriver-vendor.js"></script>
99

1010
<style>
11-
select {
11+
select, select::picker(select) {
1212
appearance: base-select;
1313
}
1414

html/semantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<script src="/resources/testdriver-actions.js"></script>
1212

1313
<style>
14-
select {
14+
select, select::picker(select) {
1515
appearance: base-select;
1616
}
1717
</style>

html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<script src="/resources/testdriver-actions.js"></script>
1111

1212
<style>
13-
select {
13+
select, select::picker(select) {
1414
appearance: base-select;
1515
}
1616
</style>

html/semantics/forms/the-select-element/stylable-select/select-option-hover-styles.tentative.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,13 @@
1212
color: SelectedItemText;
1313
background-color: SelectedItem;
1414
}
15+
select, select::picker(select) {
16+
appearance: base-select;
17+
}
1518
</style>
1619
<div id=selecteditem>SelectedItem test colors</div>
1720

18-
<select style="appearance:base-select">
21+
<select>
1922
<option class=one>one</option>
2023
<option class=two>two</option>
2124
<option class=three disabled>disabled</option>

html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html

+7-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,14 @@
66
<script src="/resources/testdriver.js"></script>
77
<script src="/resources/testdriver-vendor.js"></script>
88

9+
<style>
10+
select, select::picker(select) {
11+
appearance: base-select;
12+
}
13+
</style>
14+
915
<form>
10-
<select style="appearance:base-select">
16+
<select>
1117
<button>
1218
<selectedoption></selectedoption>
1319
</button>

0 commit comments

Comments
 (0)