style: Check types with TypeScript #137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
christian-bromann
left a comment
christian-bromann
left a comment
There was a problem hiding this comment.
Let's make sure this not convolutes the effort going on in #126 .. I don't want to cause unnecessary conflicts.
| @@ -1,5 +1,5 @@ | |||
| import { expect } from 'chai'; | |||
| import path from 'path'; | |||
| import * as path from 'path'; | |||
Collaborator
There was a problem hiding this comment.
I would be against having to do default imports like this, and keeping it like this instead:
Suggested change
| import * as path from 'path'; | |
| import path from 'path'; |
Contributor
Author
Oh, right, I forgot about that. I pushed my changes from a WIP branch. I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small PR that adds TypeScript to check types in JavaScript. There are more rules to configure and fix (later).
Checklist