-
Notifications
You must be signed in to change notification settings - Fork 727
[Docs Bug] npm webhint (hint) page: 404s #3792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is because we optimized for local links when publishing so you open the local version. Looks like there is an issue between npm an mono repos when they create the links automatically. Options:
|
Like this? From https://docs.npmjs.com/files/package.json#repository: If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:
|
Yes, like this. I believe we tried that a while ago but wasn't working but maybe we should try again? |
@johnemau Tony thinks we already implement this fix above, and that it's possible this may be a bug on npm. Do you mind taking a look? |
@molant, after researching the root cause in npm (npm/marky-markdown#449) I went with this fix (#3937) from your comment. Can you clarify how this might "mess with the link transformation step" ? How can I check if this is the case? |
Good question. Before we were cloning the latest version of master in webhint.io, but now we are pulling the latest npm packages. I think that a way would be clone the website's repo locally, install all dependencies, manually update a couple of the files you've modified, and then run the generation scripts to see what comes out of that. |
hint-axe docs are now generated at build time so the relative path is only good for post build local install of the repository and results in 404s for anyone browsing github or npmjs.org (the more common scenario). To give the best experience for the more common scenario this change directs the links to webhint.io which will have the information from the latest release. Follow-up to #3937 Fixes #3792
@molant, tested it out after webhintio/webhintio.github.io#934, and my fix worked #3967 |
Some links on the following npmjs.org pages 404. https://www.npmjs.com/package/hint/v/6.0.7#further-reading https://www.npmjs.com/package/@hint/hint-compat-api/v/4.3.5#hints https://www.npmjs.com/package/@hint/hint-babel-config/v/2.4.6#hints https://www.npmjs.com/package/@hint/hint-typescript-config/v/2.4.6#hints https://www.npmjs.com/package/@hint/hint-webpack-config/v/2.4.6#hints This is caused by npm/marky-markdown#449 The workaround is to provide fully qualified URLs to GitHub in the README.md files, this is already a pattern in some hint/packages. - - - - - - - - - - - - - - - - - - - - Fixes #3792 Close #3937
hint-axe docs are now generated at build time so the relative path is only good for post build local install of the repository and results in 404s for anyone browsing github or npmjs.org (the more common scenario). To give the best experience for the more common scenario this change directs the links to webhint.io which will have the information from the latest release. - - - - - - - - - - - - - - - - - - - - Ref #3937 Fix #3792 Close #3967 Co-authored-by: Tony Ross <[email protected]>
📚 npm webhint (hint) Quick start user guide page: 404s
Perusing the NPM page and several links are broken.
The text was updated successfully, but these errors were encountered: