Skip to content

Commit 4ff36db

Browse files
committedSep 17, 2019
Fix: Display full changelog
The project had different versions of the same package because of how hoisting works, `hint`'s `optionalDependencies` (the configurations are not the latest ones) and how npm handles duplicates and `package-lock.json`. By removing `package-lock.json` npm will always go fetch the latest version of the packages and avoid these issues. Also all packages will be installed in `node_modules` and not inside another folder under it. Because multiple versions of the same package, the changelog was not always accurate. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Fix #825
1 parent 5b6c47f commit 4ff36db

File tree

4 files changed

+3
-20996
lines changed

4 files changed

+3
-20996
lines changed
 

‎.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
.DS_Store
44
.vscode/
55
db.json
6+
package-lock.json
67
dist/
78
node_modules/
89
src/content-replaced

‎helpers/update-site/documentation.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,8 @@ const createHintCategories = (files) => {
725725
};
726726

727727
const updateChangelog = async () => {
728-
const files = await globby([`${constants.dirs.NODE_MODULES}/{hint,vscode-webhint,@hint/{${resources.join(',')},configuration-all/node_modules/{vscode-webhint,@hint/{${resources.join(',')}}}-*}}/CHANGELOG.md`]);
728+
/** All packages should be hoisted so no need to look inside `configuration-all` */
729+
const files = await globby([`${constants.dirs.NODE_MODULES}/{hint,vscode-webhint,@hint/{${resources.join(',')}}-*}/CHANGELOG.md`]);
729730

730731
const changelog = await files.reduce(async (totalPromise, file) => {
731732
const total = await totalPromise;

0 commit comments

Comments
 (0)