Merge pull request #906 from webhintio/azure-pipelines

Update yaml to update slot deployment creds + add exponential backoff to intermittently failing integration tests

Author: utsavized

azure-pipelines.yml

@@ -31,15 +31,15 @@ jobs:
   - script: npm run test-staging && node helpers/integration-tests/index.js
     displayName: 'Analyze staging with webhint'
     condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/master'))
-  - bash: |
-      az login --service-principal -u $AZURE_SERVICE_PRINCIPAL -p $AZURE_SERVICE_PRINCIPAL_PASSWORD --tenant $AZURE_TENANT
-      az webapp deployment slot swap -g webhint-web -n sonarwhal --slot staging
+  - task: AzureAppServiceManage@0
     displayName: 'Swap into production'
     condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/master'))
-    env:
-      AZURE_SERVICE_PRINCIPAL: $(AZURE_SERVICE_PRINCIPAL)
-      AZURE_SERVICE_PRINCIPAL_PASSWORD: $(AZURE_SERVICE_PRINCIPAL_PASSWORD)
-      AZURE_TENANT: $(AZURE_TENANT)
+    inputs:
+      azureSubscription: 'webhint-web'
+      Action: 'Swap Slots'
+      WebAppName: 'sonarwhal'
+      ResourceGroupName: 'webhint-web'
+      SourceSlot: 'staging'
   - bash: |
       curl https://www.google.com/ping?sitemap=https://webhint.io/sitemap.xml
       curl https://www.bing.com/ping?sitemap=https://webhint.io/sitemap.xml

helpers/integration-tests/index.js

@@ -8,9 +8,9 @@ const runIntegrationTests = async () => {
 
     try {
         for (const test of [runStaticTests, runScannerTest]) {
-            const errorFound = await test();
+            const success = await test();
 
-            if (errorFound) {
+            if (!success) {
                 error = true;
             }
         }

helpers/integration-tests/scanner.js

@@ -22,7 +22,7 @@ const runScannerTest = async () => {
             }! => Status: ${response.status()}`
         );
 
-        return response.status() !== 200;
+        return response.status() === 200;
     } catch (error) {
         console.error('🚨 Something went wrong while executing Puppeteer: ', error);
         await browser.close();

helpers/integration-tests/staticUrls.js

@@ -7,6 +7,13 @@ const staticURLsToVerify = [
     'https://sonarwhal-staging.azurewebsites.net/docs/user-guide/hints/'
 ];
 
+const backOffTime = 5000;
+const maxRetries = 3;
+
+const delay = (ms) => {
+    return new Promise(resolve => setTimeout(resolve, ms));
+};
+
 const runPuppeteer = async (url) => {
     const browser = await puppeteer.launch();
 
@@ -32,17 +39,23 @@ const runPuppeteer = async (url) => {
 };
 
 const runStaticTests = async () => {
-    let errorFound = false;
+    let success = true;
+    let retryCount = 0;
+    let resultStatus = null;
 
     for (const url of staticURLsToVerify) {
-        const resultStatus = await runPuppeteer(url);
+        resultStatus = await runPuppeteer(url);
 
-        if (resultStatus !== 200) {
-            errorFound = true;
+        while(resultStatus !== 200 && retryCount < maxRetries) {
+            console.log('Test failed, retrying... Attempt #' + (++retryCount));
+            await delay(backOffTime * retryCount);
+            resultStatus = await runPuppeteer(url);
         }
+
+        success = success && resultStatus === 200;
     }
 
-    return errorFound;
+    return success;
 };
 
 module.exports = { runStaticTests };