Fix: Remove empty categories from the result page

Fix #869

Author: sarvaje

package.json

@@ -1,7 +1,7 @@
 {
   "dependencies": {
-    "@hint/formatter-html": "^4.1.12",
-    "@hint/utils": "^7.0.0",
+    "@hint/formatter-html": "^4.1.13",
+    "@hint/utils": "^7.0.1",
     "@hint/utils-i18n": "^1.0.0",
     "algoliasearch": "^3.35.1",
     "applicationinsights": "^1.6.0",
@@ -20,7 +20,7 @@
   },
   "devDependencies": {
     "@hint/artwork": "^2.2.1",
-    "@hint/configuration-all": "^2.0.2",
+    "@hint/configuration-all": "^2.0.3",
     "cross-env": "^6.0.3",
     "eslint": "^6.7.2",
     "gulp": "^4.0.2",

src/server/routes/scanner.js

@@ -105,9 +105,6 @@ const processHintResults = async (scanResult) => {
         version: scanResult.webhintVersion
     });
 
-    result.removeCategory('other');
-    result.removeCategory('development');
-
     result.showError = hints.every((hint) => {
         return hint.messages.length === 1 && hint.messages[0].message === 'Error in webhint analyzing this hint';
     });
@@ -125,6 +122,25 @@ const processHintResults = async (scanResult) => {
         }
     });
 
+    const categoriesToRemove = [];
+
+    for (const category of result.categories) {
+        const passedCount = category.passed ? category.passed.length : 0;
+        const hintsCount = category.hints ? category.hints.length : 0;
+
+        /*
+         * If there is no hints in the category, add the category
+         * to the list of categories to remove.
+         */
+        if (passedCount + hintsCount === 0) {
+            categoriesToRemove.push(category.name.toLowerCase());
+        }
+    }
+
+    for (const category of categoriesToRemove) {
+        result.removeCategory(category);
+    }
+
     result.id = scanResult.id;
     result.permalink = `${webhintUrl}scanner/${scanResult.id}`;
 

src/webhint-theme/source/js/scanner-submit.js

@@ -205,8 +205,6 @@
                 updateAsPass(category);
             }
 
-            filterNewUpdates(category);
-
             category.hintsToUpdate = filterNewUpdates(category);
 
             updateErrorItems(category);