Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer integration tests during deployment are intermittently failing #907

Closed
utsavized opened this issue May 26, 2020 · 2 comments · Fixed by #906
Closed

Puppeteer integration tests during deployment are intermittently failing #907

utsavized opened this issue May 26, 2020 · 2 comments · Fixed by #906
Assignees
Milestone

Comments

@utsavized
Copy link
Contributor

No description provided.

@utsavized utsavized added this to the 2005-2 milestone May 26, 2020
@utsavized utsavized self-assigned this May 26, 2020
@molant
Copy link
Member

molant commented May 26, 2020

Could this be related to the server code not being ready?
I believe the node part of the site will not get started until there's a request to it, and it might take a few seconds to get it ready (and connection might be dropped?).

In another project what we ended up doing for testing before swapping was to just do requests until we get the page. I think we had a limit of 5 requests and we waited about 30 seconds in between 🤔

@utsavized
Copy link
Contributor Author

Could this be related to the server code not being ready?

This is what I suspected as well. I added a simple exponential back-off logic in the other PR to see if a 5/10/15 second back-off between retries fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment