Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mapping links to full URLs from hint GitHub repo #933

Closed
antross opened this issue Aug 12, 2020 · 1 comment · Fixed by #934
Closed

Support mapping links to full URLs from hint GitHub repo #933

antross opened this issue Aug 12, 2020 · 1 comment · Fixed by #934

Comments

@antross
Copy link
Member

antross commented Aug 12, 2020

What the website is doing is getting these type of links:

/* This regex should match the following examples:
     * * [link label]: ./somewhere.md → \s
     * * [link label]:./somewhere.md → :
     * * [link](./somewhere.md)  → \(
*/

And converting them to a "local" website.

If we add a full URL, for know it will going to keep it as is (IIRC). So the link instead of keeping inside the website, will go to the github documentation.

I think we need to add another rule to process urls that points to the hint repo.

Originally posted by @sarvaje in webhintio/hint#3937 (comment)

@antross
Copy link
Member Author

antross commented Aug 12, 2020

This will support related changes to make these links work on MDN.

E.g. when the following change to links is made in the linked PR

-[is-valid]: ./docs/is-valid.md
+[is-valid]: https://github.com/webhintio/hint/blob/HEAD/packages/hint-babel-config/docs/is-valid.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants