Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Proxy Parameter is not URL-Decoded #67

Open
DigitalGoldfish opened this issue Aug 7, 2012 · 1 comment
Open

Upstream Proxy Parameter is not URL-Decoded #67

DigitalGoldfish opened this issue Aug 7, 2012 · 1 comment

Comments

@DigitalGoldfish
Copy link

I use the Apache HttpComponents to communicate with the REST interface of the Proxy. When I start a new proxy using a URL generated like the next code fragment, the HttpComponents url encode the httpProxy parameter.

URIBuilder builder = new URIBuilder();
builder.setScheme("http")
    .setHost(browserMobHost)
    .setPort(this.browserMobPort)
    .setPath("/proxy")
    builder.setParameter("httpProxy", "172.16.96.10:8001");

However the REST-Interface does not decode the parameter thus resulting in an ArrayIndexOutOfBoundsException in BrowserMobHttpClient (Line 935). I believe that the URL-Parameters should be decoded in the REST Interface, however I am unsure if this can have negative side effects for people using the REST interface without URL-Encoded parameters.

@lightbody
Copy link
Member

I don't fully understand what you're trying to do here. Can you expand your example code or provide a test case? I think I just need a bit more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants