Skip to content

Upstream Proxy Parameter is not URL-Decoded #67

Open
@DigitalGoldfish

Description

@DigitalGoldfish

I use the Apache HttpComponents to communicate with the REST interface of the Proxy. When I start a new proxy using a URL generated like the next code fragment, the HttpComponents url encode the httpProxy parameter.

URIBuilder builder = new URIBuilder();
builder.setScheme("http")
    .setHost(browserMobHost)
    .setPort(this.browserMobPort)
    .setPath("/proxy")
    builder.setParameter("httpProxy", "172.16.96.10:8001");

However the REST-Interface does not decode the parameter thus resulting in an ArrayIndexOutOfBoundsException in BrowserMobHttpClient (Line 935). I believe that the URL-Parameters should be decoded in the REST Interface, however I am unsure if this can have negative side effects for people using the REST interface without URL-Encoded parameters.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions