Remove static from GraphQL\Validator\Rules\ValuesOfCorrectType #851

Activity

1. spawnia commented on Apr 26, 2021

   

   spawnia

   on Apr 26, 2021

   Collaborator

   More actions

   There seems to be no added benefit in having these static.

   Those methods can be called without class instantiation, this is done from tests. How would removing static improve extensibility?

   I think the deciciding difference is in how those methods are called. self::method() prevents overrides, while static::method() works.
2. spawnia

   added

   question

   on Apr 26, 2021
3. wimski commented on Apr 26, 2021

   

   wimski

   on Apr 26, 2021

   ContributorAuthor

   More actions

   Those methods can be called without class instantiation, this is done from tests.

   So the only reason they are static is because of tests?

   I think the deciciding difference is in how those methods are called. self::method() prevents overrides, while static::method() works.

   Then replacing self with static would also work for my case.
4. spawnia commented on Apr 26, 2021

   

   spawnia

   on Apr 26, 2021

   Collaborator

   More actions

   So the only reason they are static is because of tests?

   I just named one reason, there may be many.

   Another one I can think of right now is that static methods are generally easier to reason about; one does (generally) not have to worry about state with them.

   Then replacing self with static would also work for my case.

   Yes. Accepting PRs, but preferrably one that opens up all validation rules for extensibility to ensure consistency.
5. spawnia

   closed this as completedin #854on Apr 28, 2021