Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename or make an alias from notes.webplatform.org/embed.js to notes.webplatform.org/annotator.js #105

Closed
renoirb opened this issue Feb 5, 2015 · 4 comments
Closed

Rename or make an alias from notes.webplatform.org/embed.js to notes.webplatform.org/annotator.js #105

renoirb opened this issue Feb 5, 2015 · 4 comments
Labels
Annotations critical
Milestone
Upgrade-production

Comments

@renoirb
Copy link
Member

renoirb commented Feb 5, 2015

shepazu: Could we make the embed URL more obvious.
Could we change the URL to https://notes.webplatform.org/annotator.js ?

Technical assessment

Here is the piece of code involved. Let’s see how we could make this change in our [parent project].
@renoirb
Copy link
Member Author

renoirb commented Feb 5, 2015

@shepazu let’s keep this here until we work on next hypothesis software version upgrade

@renoirb renoirb closed this as completed Feb 9, 2015
@renoirb renoirb added this to the Upgrade-production milestone Feb 18, 2015
@renoirb renoirb reopened this Feb 26, 2015
@renoirb renoirb closed this as completed Feb 28, 2015
@renoirb
Copy link
Member Author

renoirb commented Feb 28, 2015

Mistakenly closed

@renoirb renoirb reopened this Feb 28, 2015
@renoirb renoirb self-assigned this Mar 11, 2015
@renoirb
Copy link
Member Author

renoirb commented Mar 20, 2015

What´s the objective of this task? At this time NGINX config gives the same file for both addresses, we might just leave it as is.

@renoirb
Copy link
Member Author

renoirb commented Apr 28, 2015

Do not forget to do this while doing #132

@renoirb renoirb removed their assignment Sep 21, 2015
@renoirb renoirb closed this as completed Sep 21, 2015
@renoirb renoirb removed the 4 - Done label Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Annotations critical
Projects
None yet
Milestone
Upgrade-production
Development

No branches or pull requests
1 participant
@renoirb