Skip to content

Commit 01a0303

Browse files
committed
refactor: remove probes for easier local dev
1 parent 01b8f50 commit 01a0303

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

chart/templates/backend.yaml

+6-3
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ spec:
5555
- name: api
5656
image: {{ .Values.backend_image }}
5757
imagePullPolicy: {{ .Values.backend_pull_policy }}
58-
{{- if .Values.backend_api_command_override }}
58+
{{- if .Values.skaffold_dev }}
5959
command:
6060
{{- range .Values.backend_api_command_override }}
6161
- {{ . | quote }}
@@ -147,7 +147,7 @@ spec:
147147
- name: op
148148
image: {{ .Values.backend_image }}
149149
imagePullPolicy: {{ .Values.backend_pull_policy }}
150-
{{- if .Values.backend_op_command_override }}
150+
{{- if .Values.skaffold_dev }}
151151
command:
152152
{{- range .Values.backend_op_command_override }}
153153
- {{ . | quote }}
@@ -198,6 +198,7 @@ spec:
198198
cpu: {{ .Values.backend_cpu }}
199199
memory: {{ .Values.backend_memory }}
200200

201+
{{- if not (.Values.skaffold_dev) }}
201202
startupProbe:
202203
httpGet:
203204
path: /healthz
@@ -206,6 +207,7 @@ spec:
206207
periodSeconds: 5
207208
failureThreshold: 5
208209
successThreshold: 1
210+
{{- end }}
209211

210212
readinessProbe:
211213
httpGet:
@@ -216,6 +218,7 @@ spec:
216218
failureThreshold: 5
217219
successThreshold: 1
218220

221+
{{- if not (.Values.skaffold_dev) }}
219222
livenessProbe:
220223
httpGet:
221224
path: /healthz
@@ -224,7 +227,7 @@ spec:
224227
periodSeconds: 30
225228
failureThreshold: 15
226229
successThreshold: 1
227-
230+
{{- end }}
228231

229232

230233
---

skaffold.yaml

+4-2
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ deploy:
5555
# we hardcoded this earlier so make sure it has same value
5656
# across the helm chart
5757
opPort: 8756
58+
# we need to override some settings for skaffold dev
59+
skaffold_dev: true
5860
# hot reloading doesn't work with default gunicorn command
5961
# so need to override to use uvicorn
6062
# plus need to start the process with debugpy to debug
@@ -64,7 +66,7 @@ deploy:
6466
- >
6567
pip install --no-input debugpy
6668
&&
67-
python -m debugpy --listen 0.0.0.0:5678
69+
python -Xfrozen_modules=off -m debugpy --listen 0.0.0.0:5678
6870
-m uvicorn btrixcloud.main:app_root
6971
--reload --host 0.0.0.0 --port 8000
7072
backend_op_command_override:
@@ -73,6 +75,6 @@ deploy:
7375
- >
7476
pip install --no-input debugpy
7577
&&
76-
python -m debugpy --listen 0.0.0.0:5679
78+
python -Xfrozen_modules=off -m debugpy --listen 0.0.0.0:5679
7779
-m uvicorn btrixcloud.main_op:app_root
7880
--reload --host 0.0.0.0 --port 8756

0 commit comments

Comments
 (0)