Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Validate exclusion regexes on backend #2253

Closed
ikreymer opened this issue Dec 17, 2024 · 1 comment
Closed

[Feature]: Validate exclusion regexes on backend #2253

ikreymer opened this issue Dec 17, 2024 · 1 comment
Assignees
@ikreymer
Labels
enhancement New feature or request

Comments

@ikreymer
Copy link
Member

What change would you like to see?

Although frontend mostly has validation, we should also validate regex entries for exclusions on the backend, to ensure that are no invalid regexes in the exclude or include values in seed scope.

Context

If an invalid regex is entered, it can cause the crawler to crash immediately, w/o good error message for the user at the moment. Best solution is we ensure no invalid regexes are added to the crawl workflow.
@ikreymer ikreymer added the enhancement New feature or request label Dec 17, 2024
@ikreymer ikreymer self-assigned this Dec 17, 2024
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Dec 17, 2024
@ikreymer
Copy link
Member Author

This was fixed via #2316!

@github-project-automation github-project-automation bot moved this from Todo to Done! in Webrecorder Projects Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

Labels
enhancement New feature or request
Projects
Webrecorder Projects
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikreymer