Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: SVG logo breaks png preview generation (easily reproducible) #474

Closed
KemingHe opened this issue Dec 21, 2024 · 3 comments
Closed
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@KemingHe
Copy link
Collaborator

Bug

When using custom SVG logo for preview, the logo disappears when downloading in PNG format. The logo shows up fine if using URL to dynamically render the preview.

To Reproduce

  1. Go to https://socialify.git.ci/wei/socialify/image?logo=https%3A%2F%2Fraw.githubusercontent.com%2Fwei%2Fsocialify%2F1f520b6bfe799300bcff9edcdc330828d681d382%2Fapp%2Ficon.svg&name=1&theme=Light
  2. Click URL and paste into a new tab/window to view the working preview (with logo).
  3. Click DOWNLOAD and select the .png option to view the bugged preview (missing logo).

SVG logo used

https://raw.githubusercontent.com/wei/socialify/1f520b6bfe799300bcff9edcdc330828d681d382/app/icon.svg

Image url (dynamically rendered) with correct logo

socialify-custom-preview

Downloaded png file with bugged (missing) logo

preview-png-with-bugged-logo

JPEG (and webp) works fine

socialify

Speculation

This might have something to do with only how PNGs are generated.

@wei
Copy link
Owner

wei commented Dec 21, 2024

Thanks for the detailed repro. Likely something we can take care of when upgrading satori #449

@wei wei added bug Something isn't working help wanted Extra attention is needed labels Dec 21, 2024
@wei
Copy link
Owner

wei commented Dec 22, 2024

@KemingHe
Copy link
Collaborator Author

Better reproduced and isolated in #488, closing as duplicate.

@KemingHe KemingHe closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants