Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flake-pep3101 dependency #1173

Closed
sobolevn opened this issue Feb 22, 2020 · 4 comments
Closed

Remove flake-pep3101 dependency #1173

sobolevn opened this issue Feb 22, 2020 · 4 comments
Assignees
@sobolevn
Labels
dependencies Pull requests that update a dependency file feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers
Milestone
Version 0.14 aka ...

Comments

@sobolevn
Copy link
Member

We need to vendor this dependency to our own codebase:

  • create new violation
  • create new logical check
  • write tests

Implementation: https://github.com/gforcada/flake8-pep3101/blob/master/flake8_pep3101.py

Related: #1139
@sobolevn sobolevn added feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers dependencies Pull requests that update a dependency file labels Feb 22, 2020
@sobolevn sobolevn added this to the Version 0.14 aka python3.8 milestone Feb 22, 2020
@jigi-33
Copy link
Contributor

jigi-33 commented Feb 25, 2020

Hey coolleagues. I would take on this issue, may I do?

@sobolevn
Copy link
Member Author

Sure! Thank you! Make sure to read our contributing guides

I am here to help: ask anything you need.

@jigi-33
Copy link
Contributor

jigi-33 commented Feb 28, 2020

So...I couldn't figure out this issue. Please re-assign to another who will done it :( Sorry

@sobolevn
Copy link
Member Author

No problem, someone else can take it. Thank you for your time and effort!

@sobolevn sobolevn self-assigned this Mar 4, 2020
@sobolevn sobolevn mentioned this issue Mar 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
dependencies Pull requests that update a dependency file feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers
Projects
None yet
Milestone
Version 0.14 aka python3.8
Development

No branches or pull requests
2 participants
@sobolevn @jigi-33