Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WPS2xx rules that are managed by Ruff #3286

Open
rusmux opened this issue Jan 22, 2025 · 3 comments
Open

Remove WPS2xx rules that are managed by Ruff #3286

rusmux opened this issue Jan 22, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@rusmux
Copy link

rusmux commented Jan 22, 2025

What's wrong

In version 1.0.0 many rules were removed in favour of the same rules in Ruff. Why some of the WPS2xx rules were not removed, even though they have a counterpart in Ruff? For example: WPS210, WPS211, WPS213, WPS231 are covered by Ruff PLR0912, PLR0913, PLR0914, PLR0917, C901

How it should be

Some of the WPS2xx rules should be removed

Flake8 version and plugins

{
"platform": {
"python_implementation": "CPython",
"python_version": "3.12.8",
"system": "Darwin"
},
"plugins": [
{
"plugin": "mccabe",
"version": "0.7.0"
},
{
"plugin": "pycodestyle",
"version": "2.12.1"
},
{
"plugin": "pyflakes",
"version": "3.2.0"
},
{
"plugin": "wemake-python-styleguide",
"version": "1.0.0"
}
],
"version": "7.1.1"
}

pip information

OS information

@rusmux rusmux added the bug Something isn't working label Jan 22, 2025
@sobolevn
Copy link
Member

Sadly, we cannot do that, because they have other (wrong 🌚️️) defaults. We cannot force people to configure all rules properly :(

@sobolevn sobolevn closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
@rusmux
Copy link
Author

rusmux commented Jan 22, 2025

@sobolevn Then maybe it's better to document it somewhere and suggest how to configure Ruff to replace these rules?

@sobolevn sobolevn reopened this Jan 22, 2025
@sobolevn
Copy link
Member

Yeap, feel free to send a PR with .. note:: on these rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants