fix: prevent concurrent Helm configuration races (#688)

Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>

Author: alexey-igrychev

pkg/helm/pkg/action/action.go

@@ -724,6 +724,9 @@ func (cfg *Configuration) Init(getter genericclioptions.RESTClientGetter, namesp
 
 // SetHookOutputFunc sets the HookOutputFunc on the Configuration.
 func (cfg *Configuration) SetHookOutputFunc(hookOutputFunc func(_, _, _ string) io.Writer) {
+	cfg.mutex.Lock()
+	defer cfg.mutex.Unlock()
+
 	cfg.HookOutputFunc = hookOutputFunc
 }
 

pkg/helm/pkg/action/configuration_ai_test.go

@@ -3,32 +3,37 @@
 package action
 
 import (
+	"io"
 	"sync"
 	"testing"
 
 	"github.com/stretchr/testify/require"
 	"k8s.io/cli-runtime/pkg/genericclioptions"
 )
 
-func TestAIConfigurationInitConcurrent(t *testing.T) {
+func TestAIConfigurationInitAndSetHookOutputFuncConcurrent(t *testing.T) {
 	cfg := NewConfiguration()
 	getter := genericclioptions.NewConfigFlags(true)
-	errs := make(chan error, 2)
+	start := make(chan struct{})
+	errs := make(chan error, 1)
 	var wg sync.WaitGroup
 	wg.Add(2)
 
-	for range 2 {
-		go func() {
-			defer wg.Done()
-			errs <- cfg.Init(getter, "default", "memory")
-		}()
-	}
+	go func() {
+		defer wg.Done()
+		<-start
+		errs <- cfg.Init(getter, "default", "memory")
+	}()
+	go func() {
+		defer wg.Done()
+		<-start
+		cfg.SetHookOutputFunc(func(_, _, _ string) io.Writer { return io.Discard })
+	}()
 
+	close(start)
 	wg.Wait()
-	close(errs)
 
-	for err := range errs {
-		require.NoError(t, err)
-	}
+	require.NoError(t, <-errs)
 	require.NotNil(t, cfg.Releases)
+	require.NotNil(t, cfg.HookOutputFunc)
 }