Skip to content

Commit 355fff2

Browse files
committed
fix: pr feedback
- use enum to generate cli arg choices - fix docs typo and improve exclusivity language
1 parent a01d262 commit 355fff2

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ users may find useful:
8282
convenient for human inspection while still being usable by
8383
libraries like Shapely.
8484
* `session_type`: `"single"` or `"multi"`; if set to `"single"`, then each call
85-
to `connect()` establishes an exclusive connection to a Wherobots runtime;
86-
if set to "multi", then multiple `connect()` calls with the same arguments
87-
and credentials will connect to the sameshared Wherobots runtime;
85+
to `connect()` establishes an exclusive connection to a distinct and dedicated
86+
Wherobots runtime; if set to "multi", then multiple `connect()` calls with the
87+
same arguments and credentials will connect to the same shared Wherobots runtime;
8888
`"single"` is the default.
8989

9090
Consider multi-session for potential cost savings, but be mindful of

tests/smoke.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,9 @@
2323
parser.add_argument("--region", help="Region to connect to (ie. aws-us-west-2)")
2424
parser.add_argument(
2525
"--session-type",
26-
help="Type of session to create. 'single' or 'multi'",
26+
help="Type of session to create",
2727
default=DEFAULT_SESSION_TYPE,
28+
choices=[st.value for st in SessionType],
2829
)
2930
parser.add_argument(
3031
"--debug",

0 commit comments

Comments
 (0)