Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the black formatter ? #42

Closed
12rambau opened this issue Sep 3, 2021 · 6 comments
Closed

use the black formatter ? #42

12rambau opened this issue Sep 3, 2021 · 6 comments

Comments

@12rambau
Copy link
Contributor

12rambau commented Sep 3, 2021

AS you mentioned that using black would be a good idea (#40 (comment)). would you like to apply it on the whole lib ?

I could set up some GitHub actions (including test + formatting) at the same time.

@mariobuikhuizen
Copy link
Collaborator

Yeah, that would be great!

I experimented a bit with a pre-commit hook to enforce the code formatting

@12rambau
Copy link
Contributor Author

did you had a look at this ? https://pre-commit.com

@mariobuikhuizen
Copy link
Collaborator

Yeah, see #44.

@12rambau
Copy link
Contributor Author

My bad, I was thinking you were manually setting the pre-commit hook

@mariobuikhuizen
Copy link
Collaborator

I was in #43 :)

@12rambau
Copy link
Contributor Author

Fixed with aece22f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants