feat: add more context to error logs

lib/handle-pull-request-change.js

@@ -14,6 +14,7 @@ const overwriteLegacyCommitStatus = require('./legacy/overwrite-commit-status')
 
 async function handlePullRequestChange (app, context) {
   const { action, pull_request: pr, repository: repo } = context.payload
+  let log = context.log
 
   try {
     // 1. get new status based on marketplace plan
@@ -32,7 +33,7 @@ async function handlePullRequestChange (app, context) {
     // indefinitely, hence the override. See https://github.com/wip/app/issues/89#notes-on-update-to-marketplace-version
     const didLegacyOveride = await overwriteLegacyCommitStatus(context)
 
-    const log = getLogChild({ context, action, plan, newStatus, repo, hasChange, shortUrl, didLegacyOveride })
+    log = getLogChild({ context, action, plan, newStatus, repo, hasChange, shortUrl, didLegacyOveride })
 
     // if status did not change then don’t call .createStatus. Quotas for mutations
     // are much more restrictive so we want to avoid them if possible
@@ -41,11 +42,8 @@ async function handlePullRequestChange (app, context) {
     }
 
     // 3. Create check run
-    if (plan === 'free') {
-      await setStatusFree(newStatus, context)
-    } else {
-      await setStatusPro(newStatus, context)
-    }
+    const setStatus = plan === 'free' ? setStatusFree : setStatusPro
+    await setStatus(newStatus, context)
 
     log.stateChanged()
   } catch (error) {
@@ -55,17 +53,15 @@ async function handlePullRequestChange (app, context) {
       for (const key in parsed) {
         error[key] = parsed[key]
       }
+    } catch (e) {}
 
-      // Erro code 403 (Resource not accessible by integration) means that
-      // the user did not yet accept the new permissions, so we handle it the
-      // old school way
-      if (error.code === 403) {
-        return legacyHandler(context)
-      }
-
-      context.log.error(error)
-    } catch (e) {
-      context.log.error(error)
+    // Erro code 403 (Resource not accessible by integration) means that
+    // the user did not yet accept the new permissions, so we handle it the
+    // old school way
+    if (error.code === 403) {
+      return legacyHandler(context)
     }
+
+    log.error(error)
   }
 }

lib/legacy/handle-pull-request-change.js

@@ -46,10 +46,9 @@ async function handlePullRequestChange (context) {
       for (const key in parsed) {
         error[key] = parsed[key]
       }
-      context.log.error(error)
-    } catch (e) {
-      context.log.error(error)
-    }
+    } catch (e) {}
+
+    log.error(error)
   }
 }
 

lib/logs/get-child.js

@@ -29,6 +29,9 @@ function getChildLog ({ context, action, plan, newStatus, repo, hasChange, short
         message += ` - "${newStatus.match}" found in ${newStatus.location}`
       }
       log.info(message)
+    },
+    error (error) {
+      log.error(error)
     }
   }
 }