Skip to content

Consider: when removing a validator, do we have to update their weight first? #30

@wildmolasses

Description

@wildmolasses

Current impl will reduce their validator weight on the registry via changeValidatorWeight before removing them via remove. Should we just call remove instead?

zkstaker/src/ZkStaker.sol

Lines 475 to 477 in 3228dfa

if (_isInRegistry) {
registry.changeValidatorWeight(_validatorOwner, _newWeight);
if (!_isAboveThreshold) registry.remove(_validatorOwner);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions