forked from dragonfly-xyz/useful-solidity-patterns
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathPooledExecute.t.sol
190 lines (171 loc) · 5.67 KB
/
PooledExecute.t.sol
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
// SPDX-License-Identifier: UNLICENSED
pragma solidity ^0.8.17;
import "../patterns/error-handling/PooledExecute.sol";
import "./TestUtils.sol";
contract PooledExecuteTest is TestUtils {
event ExecuteSucceeded(bytes returnData);
event ExecuteFailed(bytes revertData);
event TargetCalled(uint256 value);
ExecuteTarget target = new ExecuteTarget();
function test_canExecuteAndSucceed() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.noop, ()),
1,
100e3
);
vm.expectEmit(false, false, false, true);
emit TargetCalled(1);
vm.expectEmit(false, false, false, true);
emit ExecuteSucceeded('');
pool.join{value: 1}();
assertEq(address(target).balance, 1);
}
function test_canExecuteAndFail() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.fail, ()),
1,
100e3
);
vm.expectEmit(false, false, false, true);
emit ExecuteFailed(abi.encodeWithSignature('Error(string)', 'fail'));
pool.join{value: 1}();
assertEq(address(target).balance, 0);
assertEq(address(pool).balance, 1);
}
function test_refundsExcessEth() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.noop, ()),
2,
100e3
);
vm.deal(address(pool), 1);
address contributor = _randomAddress();
vm.deal(contributor, 2);
vm.prank(contributor);
pool.join{value: 2}();
assertEq(contributor.balance, 1);
}
function test_doesNotExecuteIfNotEnoughEth() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.noop, ()),
2,
100e3
);
pool.join{value: 1}();
assertEq(uint8(pool.executeResult()), uint8(PooledExecute.ExecuteResult.NotExecuted));
}
function test_cannotReenterJoin() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.reenterJoin, ()),
1,
100e3
);
vm.expectEmit(false, false, false, true);
emit ExecuteFailed(abi.encodeWithSignature('Error(string)', 'already executed'));
pool.join{value: 1}();
}
function test_cannotReenterWithdraw() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.reenterWithdraw, ()),
1,
100e3
);
vm.expectEmit(false, false, false, true);
emit ExecuteFailed(abi.encodeWithSignature('Error(string)', 'execution hasn\'t failed'));
pool.join{value: 1}();
}
function test_cannotExecuteTwice() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.noop, ()),
1,
100e3
);
vm.expectEmit(false, false, false, true);
emit ExecuteSucceeded('');
pool.join{value: 1}();
vm.expectRevert('already executed');
pool.join{value: 1}();
}
function test_cannotExecuteWithTooLittleGas() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.reenterWithdraw, ()),
1,
100e3
);
vm.expectRevert('not enough gas left');
pool.join{value: 1, gas: 100e3}();
}
function test_cannotWithdrawBeforeFailing() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.noop, ()),
2,
100e3
);
pool.join{value: 1}();
vm.expectRevert('execution hasn\'t failed');
pool.withdraw();
}
function test_canWithdrawAfterFailing() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.fail, ()),
1,
100e3
);
address contributor = _randomAddress();
vm.deal(contributor, 1);
vm.expectEmit(false, false, false, true);
emit ExecuteFailed(abi.encodeWithSignature('Error(string)', 'fail'));
vm.prank(contributor);
pool.join{value: 1}();
assertEq(contributor.balance, 0);
vm.prank(contributor);
pool.withdraw();
assertEq(contributor.balance, 1);
}
function test_cannotWithdrawTwice() external {
PooledExecute pool = new PooledExecute(
address(target),
abi.encodeCall(target.fail, ()),
1,
100e3
);
address contributor = _randomAddress();
vm.deal(contributor, 1);
vm.expectEmit(false, false, false, true);
emit ExecuteFailed(abi.encodeWithSignature('Error(string)', 'fail'));
vm.prank(contributor);
pool.join{value: 1}();
assertEq(contributor.balance, 0);
vm.prank(contributor);
pool.withdraw();
assertEq(contributor.balance, 1);
vm.prank(contributor);
pool.withdraw();
assertEq(contributor.balance, 1);
}
}
contract ExecuteTarget {
event TargetCalled(uint256 value);
function noop() external payable {
emit TargetCalled(msg.value);
}
function fail() external payable {
revert('fail');
}
function reenterJoin() external payable {
PooledExecute(msg.sender).join();
}
function reenterWithdraw() external payable {
PooledExecute(msg.sender).withdraw();
}
}