From fcda27f02e9871d775439b255b1b7984b69e7ebc Mon Sep 17 00:00:00 2001 From: DanielPharos_cp Date: Sat, 20 May 2017 08:39:23 +0000 Subject: [PATCH] Quoted the path for the Task, so that install paths with spaces work too. --- Console/Helpers/InstallHelper.cs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/Console/Helpers/InstallHelper.cs b/Console/Helpers/InstallHelper.cs index a99c1210..06504068 100644 --- a/Console/Helpers/InstallHelper.cs +++ b/Console/Helpers/InstallHelper.cs @@ -150,14 +150,15 @@ private static bool CreateDefaultRules() private static bool createTask(bool allUsers) { string tmpXML = Path.GetTempFileName(); - var taskStr = new StreamReader(Assembly.GetExecutingAssembly().GetManifestResourceStream("Wokhan.WindowsFirewallNotifier.Console.Resources.TaskTemplate.xml")); - var newtask = String.Format(taskStr.ReadToEnd(), - allUsers ? "NT AUTHORITY\\SYSTEM"//"S-1-5-32-545" - : "", - Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Notifier.exe"), - DateTime.Now.ToString("s")); - - taskStr.Close(); + string newtask; + using (var taskStr = new StreamReader(Assembly.GetExecutingAssembly().GetManifestResourceStream("Wokhan.WindowsFirewallNotifier.Console.Resources.TaskTemplate.xml"))) + { + newtask = String.Format(taskStr.ReadToEnd(), + allUsers ? "NT AUTHORITY\\SYSTEM"//"S-1-5-32-545" + : "", + "\"" + Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Notifier.exe") + "\"", + DateTime.Now.ToString("s")); + } File.WriteAllText(tmpXML, newtask, Encoding.Unicode);