Skip to content

Commit 7cd080b

Browse files
authored
Merge pull request #8713 from JacobBarthelmeh/scan
use proper heap hint when free'ing CRL in error case
2 parents 0adb6eb + 2037586 commit 7cd080b

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/crl.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -856,13 +856,18 @@ int GetCRLInfo(WOLFSSL_CRL* crl, CrlInfo* info, const byte* buff,
856856
static WOLFSSL_X509_CRL* wolfSSL_X509_crl_new(WOLFSSL_CERT_MANAGER* cm)
857857
{
858858
WOLFSSL_X509_CRL* ret;
859+
void* heap = NULL;
859860

860-
ret = (WOLFSSL_X509_CRL*)XMALLOC(sizeof(WOLFSSL_X509_CRL),
861-
cm != NULL ? cm->heap : NULL, DYNAMIC_TYPE_CRL);
861+
if (cm != NULL) {
862+
heap = cm->heap;
863+
}
864+
865+
ret = (WOLFSSL_X509_CRL*)XMALLOC(sizeof(WOLFSSL_X509_CRL), heap,
866+
DYNAMIC_TYPE_CRL);
862867
if (ret != NULL) {
863868
if (InitCRL(ret, cm) < 0) {
864869
WOLFSSL_MSG("Unable to initialize new CRL structure");
865-
XFREE(ret, cm->heap, DYNAMIC_TYPE_CRL);
870+
XFREE(ret, heap, DYNAMIC_TYPE_CRL);
866871
ret = NULL;
867872
}
868873
}

0 commit comments

Comments
 (0)