Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag behavior is inconsistent with the common behavior #357

Open
Jackjun724 opened this issue Dec 23, 2024 · 4 comments
Open

Drag behavior is inconsistent with the common behavior #357

Jackjun724 opened this issue Dec 23, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Jackjun724
Copy link

I tried the dragging of ModalSheet in iOS and YouTube, and they share a common characteristic: even if I drag a very short distance, as long as the dragging speed is fast enough, they will be closed. In this repository, even if I drag it very fast, I still need to drag it to the bottom of the screen, which makes this feature particularly useless for mobile users, as it is difficult for me to close it using gestures.

@Jackjun724 Jackjun724 added the enhancement New feature or request label Dec 23, 2024
@ulusoyca
Copy link
Collaborator

ulusoyca commented Dec 25, 2024

Hello @Jackjun724 ! Thanks for opening the issue. We are using the same default values for Android and iOS coming from the implementation in Flutter SDK. However, it is possible to customize these values by extending the WoltModalType class and setting up closeProgressThreshold and minFlingVelocity

More info in this API rference: https://pub.dev/documentation/wolt_modal_sheet/latest/wolt_modal_sheet/WoltBottomSheetType-class.html

Also the usage example: https://github.com/woltapp/wolt_modal_sheet/blob/main/example/lib/main.dart#L214

@Jackjun724
Copy link
Author

Thank you for your reply. I believe that YouTube represents Material design, so no matter on iOS or Android, this sliding close cannot be better in line with users' default intuition. Perhaps you can try it, although it is just a small detail.

@ulusoyca
Copy link
Collaborator

ulusoyca commented Jan 7, 2025

@Jackjun724 thanks for the reply. What would be action point here? Adjusting the default values according to Material specs?

@Jackjun724
Copy link
Author

@Jackjun724 thanks for the reply. What would be action point here? Adjusting the default values according to Material specs?

Adjusting the default values or add simple options.

Possibly my English is not ideal. In fact, it's quite difficult for me to close WoltSheet with a single hand on my phone, as it requires me to tilt the phone. In contrast, closing comments on YouTube is easily done with a single hand. For this reason, I changed the Sheet library, because there is nothing more important than making user operations convenient, even though Wolt's UI is so perfect. To you, salutations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants