Skip to content

Conversation

@JorgeMucientes
Copy link
Contributor

Closes: WOOMOB-1702

Description

Adds support for basic auth when fetching site nonce using site credentials

Test Steps

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@JorgeMucientes JorgeMucientes added the feature: login Related to any part of the log in or sign in flow, or authentication. label Nov 13, 2025
@JorgeMucientes JorgeMucientes added this to the 23.7 milestone Nov 13, 2025
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitac7d739
Direct Downloadwoocommerce-wear-prototype-build-pr14942-ac7d739.apk

@wpmobilebot
Copy link
Collaborator

🤖 Test Failure Analysis

Your tests failed. Claude has analyzed the failures - check the annotation for details.

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitac7d739
Direct Downloadwoocommerce-prototype-build-pr14942-ac7d739.apk

@wzieba
Copy link
Contributor

wzieba commented Nov 13, 2025

👋 @JorgeMucientes I know it's only a draft, but just in case if it'll be helpful I'd like to share a few comments:

  • HTTP Basic Auth can be authorized with different credentials than WP. They are indeed sometimes the same (like in Pressable) but that's not actually a rule/requirement.
  • We have a dedicated flow for HTTP Basic Auth with a different screen etc. - maybe we can use it. See:

private void askForHttpAuthCredentials(@NonNull final String url, int messageId) {

and the remaining flow that starts there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: login Related to any part of the log in or sign in flow, or authentication.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants