Skip to content

Commit 365291a

Browse files
committed
refactor: Extract async logging test helper
1 parent dec3155 commit 365291a

File tree

1 file changed

+15
-20
lines changed

1 file changed

+15
-20
lines changed

src/utils/fetch-interceptor.test.js

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@ import * as bridge from './bridge';
1111

1212
vi.mock( './bridge' );
1313

14+
// Helper to await the nested, non-blocking async logging that occurs within the
15+
// fetch interceptor.
16+
const waitForAsyncLogging = () =>
17+
new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
18+
1419
describe( 'initializeFetchInterceptor', () => {
1520
let originalFetch;
1621

@@ -88,8 +93,7 @@ describe( 'initializeFetchInterceptor', () => {
8893
body: formData,
8994
} );
9095

91-
// Wait for async logging to complete
92-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
96+
await waitForAsyncLogging();
9397

9498
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
9599
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -113,8 +117,7 @@ describe( 'initializeFetchInterceptor', () => {
113117
body: blob,
114118
} );
115119

116-
// Wait for async logging to complete
117-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
120+
await waitForAsyncLogging();
118121

119122
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
120123
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -136,8 +139,7 @@ describe( 'initializeFetchInterceptor', () => {
136139
body: file,
137140
} );
138141

139-
// Wait for async logging to complete
140-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
142+
await waitForAsyncLogging();
141143

142144
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
143145
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -157,8 +159,7 @@ describe( 'initializeFetchInterceptor', () => {
157159
body: buffer,
158160
} );
159161

160-
// Wait for async logging to complete
161-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
162+
await waitForAsyncLogging();
162163

163164
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
164165
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -180,8 +181,7 @@ describe( 'initializeFetchInterceptor', () => {
180181
body: params,
181182
} );
182183

183-
// Wait for async logging to complete
184-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
184+
await waitForAsyncLogging();
185185

186186
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
187187
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -201,8 +201,7 @@ describe( 'initializeFetchInterceptor', () => {
201201
body: jsonString,
202202
} );
203203

204-
// Wait for async logging to complete
205-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
204+
await waitForAsyncLogging();
206205

207206
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
208207
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -237,8 +236,7 @@ describe( 'initializeFetchInterceptor', () => {
237236
body: formData,
238237
} );
239238

240-
// Wait for async logging to complete
241-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
239+
await waitForAsyncLogging();
242240

243241
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
244242
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -271,8 +269,7 @@ describe( 'initializeFetchInterceptor', () => {
271269
body: formData,
272270
} );
273271

274-
// Wait for async logging to complete
275-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
272+
await waitForAsyncLogging();
276273

277274
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
278275
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -299,8 +296,7 @@ describe( 'initializeFetchInterceptor', () => {
299296
body: stream,
300297
} );
301298

302-
// Wait for async logging to complete
303-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
299+
await waitForAsyncLogging();
304300

305301
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
306302
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];
@@ -315,8 +311,7 @@ describe( 'initializeFetchInterceptor', () => {
315311

316312
await window.fetch( 'https://example.com/api' );
317313

318-
// Wait for async logging to complete
319-
await new Promise( ( resolve ) => setTimeout( resolve, 10 ) );
314+
await waitForAsyncLogging();
320315

321316
expect( bridge.onNetworkRequest ).toHaveBeenCalled();
322317
const loggedRequest = bridge.onNetworkRequest.mock.calls[ 0 ][ 0 ];

0 commit comments

Comments
 (0)