Address main-thread sanitizer issue: change tab bar index on main thread

mokagio · mokagio · commit 292bb068f2f8 · 2025-04-22T16:02:09.000+10:00
diff --git a/WordPress/Classes/System/Root View/WPTabBarController+RootViewPresenter.swift b/WordPress/Classes/System/Root View/WPTabBarController+RootViewPresenter.swift
@@ -22,8 +22,13 @@ extension WPTabBarController: RootViewPresenter {
     }
 
     func showNotificationsTab(completion: ((NotificationsViewController) -> Void)?) {
-        self.selectedIndex = WPTab.notifications.rawValue
-        completion?(self.notificationsViewController!)
+        // UITabBarController.selectedIndex must be used from main thread only.
+        DispatchQueue.main.async { [weak self] in
+            guard let self else { return }
+
+            self.selectedIndex = WPTab.notifications.rawValue
+            completion?(self.notificationsViewController!)
+        }
     }
 
     // MARK: Me

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,13 @@ extension WPTabBarController: RootViewPresenter {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`func showNotificationsTab(completion: ((NotificationsViewController) -> Void)?) {`
`25`		`- self.selectedIndex = WPTab.notifications.rawValue`
`26`		`- completion?(self.notificationsViewController!)`
	`25`	`+ // UITabBarController.selectedIndex must be used from main thread only.`
	`26`	`+ DispatchQueue.main.async { [weak self] in`
	`27`	`+ guard let self else { return }`
	`28`	`+`
	`29`	`+ self.selectedIndex = WPTab.notifications.rawValue`
	`30`	`+ completion?(self.notificationsViewController!)`
	`31`	`+ }`
`27`	`32`	`}`
`28`	`33`
`29`	`34`	`// MARK: Me`